[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 added a comment. In D141440#4044300 , @Jake-Egan wrote: > Getting a build failure on AIX, could you take a look please? > > > /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/lib/Driver/Driver.cpp:5715:37: > error:

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

Jake-Egan added a comment. Getting a build failure on AIX, could you take a look please? /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/lib/Driver/Driver.cpp:5715:37: error: lambda capture 'C' is not used [-Werror,-Wunused-lambda-capture] auto

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d9afee3d159: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode (authored by jhuber6). Repository: rG LLVM Github

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 updated this revision to Diff 488187. jhuber6 added a comment. I realized that if I fix up how we propagate the ToolChains I can use it in `ConstructPhaseAction`. Should be cleaner this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4411 ++TCAndArch; } } JonChesterfield wrote: > Why is rdc involved here? HIP goes straight through a separate linker phase in non-RDC mode. Setting the type here would

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. If i'm reading this right, the change means we emit the same save-temps files as hip with the same naming convention. That sounds great, makes life easier for backend devs

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 created this revision. jhuber6 added reviewers: arsenm, jdoerfert, tianshilei1992, yaxunl, JonChesterfield. Herald added subscribers: kosarev, kerbowa, guansong, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added