[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina abandoned this revision. eklepilkina added a comment. Herald added a subscriber: jobnoorman. Another implementation was merged to upsteam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina updated this revision to Diff 497620. eklepilkina added a comment. - [RISCV] Prepare work to be ready for adding separate Zicsr and Zifencei extensions - [RISCV] Proper support of extensions Zicsr and Zifencei - Updated I extension verson - Fixing after updating Repository: rG

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. @reames Thank you for fixing documentation, missed this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

reames added a comment. JFYI, I have a change out which just documents current status while we wait for a resolution. https://reviews.llvm.org/D143924 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. > Maybe multi-lib handling should split into another patch? I can do this. But if I separate I still can't choose one that should be merged firstly, they will be needed to merge both at once, because tests will fail. If separate them right way (fixes for multilibs

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

kito-cheng added a comment. Maybe multi-lib handling should split into another patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina updated this revision to Diff 490056. eklepilkina added a comment. - Updated I extension verson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 Files:

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. Thank you for comments! > The key aspect this patch misses right now is the versioning issue - I is > still marked as 2.0. I can update `I` extension version or separate diffrent isa versions as you mentioned. I can fix comments and make proposed by community

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

asb added a comment. Herald added a subscriber: luke. In D141666#4050692 , @eklepilkina wrote: > We are interested in proper support for `Zicsr` and `Zifencei`. Could someone > look at patch or explain why these extensions were included by default? As

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

jrtc27 added a comment. Because they used to be part of I and then a later version of the RISC-V spec split them out in an incompatible way. GCC/binutils bit the bullet and split them out last(?) year but LLVM has yet to make that breaking change. Repository: rG LLVM Github Monorepo

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. We are interested in proper support for `Zicsr` and `Zifencei`. Could someone look at patch or explain why these extensions were included by default? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,