This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
pratlucas marked an inline comment as done.
Closed by commit rG9ea00fc74c3c: [NFC][AArch64] Use optional returns in target
parser instead of invalid… (authored by
pratlucas marked an inline comment as done.
pratlucas added inline comments.
Comment at: llvm/unittests/TargetParser/TargetParserTest.cpp:1456
+ std::optional Extension =
+ AArch64::parseArchExtension(ArchExt);
+ if (!Extension)
tmatheson wrote:
> I think
tmatheson added inline comments.
Comment at: llvm/unittests/TargetParser/TargetParserTest.cpp:1456
+ std::optional Extension =
+ AArch64::parseArchExtension(ArchExt);
+ if (!Extension)
I think we still need to test getDefaultExtensions, unless we're
pratlucas created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
pratlucas requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, MaskRay.
Herald added projects: clang, LLVM.
This updates the parsing methods in
