This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG798494ed4f11: [clang][TypePrinter] Support expression
template arguments when checking… (authored by Michael137).
Repository:
rG LLVM Github
Michael137 added inline comments.
Comment at: clang/lib/AST/TypePrinter.cpp:2019
+ // Can't evaluate value-dependent expressions so bail early
+ Expr const *pattern_expr = Pattern.getAsExpr();
+ if (pattern_expr->isValueDependent() ||
aprantl wrote:
> I
Michael137 added inline comments.
Comment at: clang/lib/AST/TypePrinter.cpp:2031
+if (args_expr->isValueDependent() ||
!args_expr->isIntegerConstantExpr(Ctx))
+ return false;
+
aprantl wrote:
> Just for my own education: what's an example for a
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/AST/TypePrinter.cpp:2018
+
+ // Can't evaluate value-dependent expressions so bail early
+ Expr const *pattern_expr = Pattern.getAsExpr();
Michael137 updated this revision to Diff 492458.
Michael137 added a comment.
- Remove `dump()` leftover from debugging
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142632/new/
https://reviews.llvm.org/D142632
Files:
Michael137 added inline comments.
Comment at: clang/lib/AST/TypePrinter.cpp:2020
+ Expr const *pattern_expr = Pattern.getAsExpr();
+ pattern_expr->dump();
+ if (pattern_expr->isValueDependent() ||
erichkeane wrote:
> this left over from debugging?
Yes! Good
erichkeane added a comment.
I think this looks correct, but 1 thing I found.
Comment at: clang/lib/AST/TypePrinter.cpp:2020
+ Expr const *pattern_expr = Pattern.getAsExpr();
+ pattern_expr->dump();
+ if (pattern_expr->isValueDependent() ||
this left over
Michael137 created this revision.
Michael137 added reviewers: erichkeane, aaron.ballman, aprantl, dblaikie.
Herald added a project: All.
Michael137 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch adds support for
