[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG665e32ee0ffd: [Sanitizers] Error out for -static-libsan on darwin (authored by usama54321). Changed prior to commit: https://reviews.llvm.org/D144672?vs=502474=502569#toc Repository: rG LLVM Github

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 502474. dmaclach added a comment. Moved to `REQUIRES: asan-static-runtime` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files:

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln accepted this revision. yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + usama54321 wrote: > yln wrote: > >

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > usama54321 wrote: > > yln wrote: > > > zixuw

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + usama54321 wrote: > yln wrote: > > zixuw wrote: > > > dmaclach

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Went with unsupported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 502138. dmaclach marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > zixuw wrote: > > dmaclach wrote: > > > yln

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + zixuw wrote: > dmaclach wrote: > > yln wrote: > > > This should

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

zixuw added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + dmaclach wrote: > yln wrote: > > This should work, right? > No..

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > This should work, right? No.. darwin should fail

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

yln added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + This should work, right? Repository: rG LLVM Github Monorepo

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 501899. dmaclach added a comment. Herald added subscribers: Sanitizers, Enna1. Updated with fixed tests for `replaceable_new_delete.cpp`. Split `replaceable_new_delete.cpp` into `replaceable_new_delete_shared.cpp` and `replaceable_new_delete_static.cpp`.

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 added a comment. I have reverted the commit for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Yep. Apologies. Been a long time since I committed anything to LLVM. I'll try and take a look tonight/first thing tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 reopened this revision. usama54321 added a comment. This revision is now accepted and ready to land. @dmaclach Can you please take a look and fix this? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

zixuw added a comment. Hi! This broke the asan replaceable_new_delete.cpp test on Darwin because it has a run line using `-static-libsan`. Could you take a look? Probably need to separate that check out and mark as unsupported on Darwin Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e7d40e0928c: [Sanitizers] Error out for -static-libsan on darwin (authored by usama54321). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. @usama54321 or @yln are you able to commit for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 accepted this revision. usama54321 added a comment. This revision is now accepted and ready to land. I was verifying that static versions of these libraries are not present on darwin. Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Updated with buildable patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 500942. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files: