[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e901cda725b: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions… (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/ https://reviews.llvm.org/D145885

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe updated this revision to Diff 504537. mikecrowe edited the summary of this revision. mikecrowe added a comment. Quote types and functions correctly in redundant-string-cstr.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/redundant-string-cstr.rst:18 + or proper overload candidates that can do so should exist. This can be + used to configure functions such as fmt::format, spdlog::logger::info, +

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe updated this revision to Diff 504517. mikecrowe marked 2 inline comments as done. mikecrowe added a comment. Documentation updates suggested by @PiotrZSL. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe added a comment. In D145885#4187679 , @PiotrZSL wrote: > My only complain is documentation, changes in code and tests are correct. > Build failed mainly due to conflicts in previous change. > It should get green once prev patch will land, and

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe updated this revision to Diff 504475. mikecrowe added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/ https://reviews.llvm.org/D145885 Files:

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. My only complain is documentation, changes in code and tests are correct. Build failed mainly due to conflicts in previous change. It should get green once prev patch will land,

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146-148 + arguments to ``std::print`` and ``std::format``. The same check can be + used for functions that behave similarly by using the + ``StringParameterFunction`` option.

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe added a comment. I can squash this with https://reviews.llvm.org/D143342 if required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/ https://reviews.llvm.org/D145885 ___ cfe-commits

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe created this revision. mikecrowe added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a