[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp added a comment. > When the `.clang-tidy` file is checked into the source control(git). It means > that anyone who contributes to the project will need to ensure that they have > a version of clang-tidy that will be able to read the file. > This can cause problems as binaries of

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

njames93 added a comment. In D147876#4257197 , @carlosgalvezp wrote: > In D147876#4256182 , @njames93 > wrote: > >> with checked in configuration files > > I'm not sure I understand what you mean by "checked

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp added a comment. In D147876#4256182 , @njames93 wrote: > In D147876#4256155 , @carlosgalvezp > wrote: > >> Thanks for the review @njames93 ! Do you think it makes sense that we >> deprecate the

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

njames93 added a comment. In D147876#4256155 , @carlosgalvezp wrote: > Thanks for the review @njames93 ! Do you think it makes sense that we > deprecate the string format, so that we only support the list format? To be > fully removed in clang-tidy

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp added a comment. Thanks for the review @njames93 ! Do you think it makes sense that we deprecate the string format, so that we only support the list format? To be fully removed in clang-tidy 19. Only for config file, for `--checks` we can still support string. This would allow us

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

This revision was automatically updated to reflect the committed changes. Closed by commit rG132f1d31fd66: [clang-tidy] Support specifying checks as a list in the config file (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

njames93 accepted this revision. njames93 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:129-141 +// Special case for reading from YAML +// Must support reading from both a string or a

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:129-141 +// Special case for reading from YAML +// Must support reading from both a string or a list +Input = reinterpret_cast(IO); +if (isa(I.getCurrentNode()) ||

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:129-141 +// Special case for reading from YAML +// Must support reading from both a string or a list +Input =

[PATCH] D147876: [clang-tidy] Support specifying checks as a list in the config file

carlosgalvezp updated this revision to Diff 512114. carlosgalvezp marked 2 inline comments as done. carlosgalvezp retitled this revision from "[clang-tidy] Support introducing checks as a list in the config file" to "[clang-tidy] Support specifying checks as a list in the config file".