PiotrZSL abandoned this revision.
PiotrZSL added a comment.
I do not plan to work on this check anymore, sorry for a wasted time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
isuckatcs added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306
+
+ if (From->isMemberPointerType() || To->isMemberPointerType())
return false;
PiotrZSL wrote:
> isuckatcs wrote:
> > isuckatcs wrote:
> > >
PiotrZSL updated this revision to Diff 551776.
PiotrZSL marked an inline comment as done.
PiotrZSL added a comment.
Add throw_basefn_catch_const_basefn test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
PiotrZSL marked 2 inline comments as done.
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306
+
+ if (From->isMemberPointerType() || To->isMemberPointerType())
return false;
isuckatcs wrote:
>
isuckatcs added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306
+
+ if (From->isMemberPointerType() || To->isMemberPointerType())
return false;
isuckatcs wrote:
> PiotrZSL wrote:
> > isuckatcs wrote:
> > >
PiotrZSL updated this revision to Diff 551760.
PiotrZSL added a comment.
Rebase + Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
Files:
clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp
PiotrZSL added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
isuckatcs added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306
+
+ if (From->isMemberPointerType() || To->isMemberPointerType())
return false;
PiotrZSL wrote:
> isuckatcs wrote:
> > isuckatcs wrote:
> > >
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306
+
+ if (From->isMemberPointerType() || To->isMemberPointerType())
return false;
isuckatcs wrote:
> isuckatcs wrote:
> > Please cover this line
PiotrZSL updated this revision to Diff 530306.
PiotrZSL marked 2 inline comments as done.
PiotrZSL added a comment.
Add one test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
Files:
isuckatcs added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306
+
+ if (From->isMemberPointerType() || To->isMemberPointerType())
return false;
isuckatcs wrote:
> Please cover this line with both positive
PiotrZSL added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
PiotrZSL updated this revision to Diff 524820.
PiotrZSL added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
Files:
clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp
PiotrZSL updated this revision to Diff 524817.
PiotrZSL edited the summary of this revision.
PiotrZSL added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
Files:
isuckatcs added a comment.
Please cover the changes in as much test cases as possible.
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:151
+bool isFunctionTypeEqual(const FunctionType *From, const FunctionType *To) {
+ if (From == To)
PiotrZSL added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
PiotrZSL updated this revision to Diff 518357.
PiotrZSL added a comment.
Remove unused include
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
Files:
PiotrZSL updated this revision to Diff 518356.
PiotrZSL marked 2 inline comments as done.
PiotrZSL added a comment.
Update, added support for comparing function pointers without
exception specification.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
PiotrZSL planned changes to this revision.
PiotrZSL added a comment.
TODO: Fix function pointer compare
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148461/new/
https://reviews.llvm.org/D148461
___
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:160-162
+// FIXME: Two function pointers can differ in 'noexcept', but they still
+// should be considered to be same, now this triggers false-positive
because
+//
isuckatcs added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:160-162
+// FIXME: Two function pointers can differ in 'noexcept', but they still
+// should be considered to be same, now this triggers false-positive
because
+//
PiotrZSL created this revision.
PiotrZSL added reviewers: njames93, carlosgalvezp.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Added support for
22 matches
Mail list logo
