[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

2023-05-02 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. In D148769#4311232 , @dblaikie wrote: > I wouldn't mind a follow-up commit that creates a new/separate directory > (llvm/{lib,include/llvm}/CodeGenTypes) but that's probably a lot of > unnecessary churn too, so I can appreciate

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

2023-05-02 Thread NAKAMURA Takumi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d71ec6e448f: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT (authored by chapuni). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

2023-05-02 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni updated this revision to Diff 518722. chapuni edited the summary of this revision. chapuni added a comment. - Updat the desc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148769/new/ https://reviews.llvm.org/D148769 Files:

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

2023-05-01 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. I wouldn't mind a follow-up commit that creates a new/separate directory (llvm/{lib,include/llvm}/CodeGenTypes) but that's probably a lot of unnecessary churn too, so I can appreciate the argument against it - if folks reckon it's

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

2023-04-29 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni updated this revision to Diff 518146. chapuni added a comment. - Add comment lines to LLVMCodeGenTypes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148769/new/ https://reviews.llvm.org/D148769 Files: clang/lib/CodeGen/CMakeLists.txt

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

2023-04-29 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni added a reviewer: dblaikie. chapuni added a subscriber: dblaikie. chapuni added a comment. I am certain this works, though, I would like to ask the 2nd opinion to @dblaikie . In D148769#4297552 , @arsenm wrote: > I feel like this should have

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

2023-04-25 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wdng. I feel like this should have documentation explaining the library split, but not sure where the best place to put that would be Repository: rG LLVM Github

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT/VT

2023-04-23 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni updated this revision to Diff 516182. chapuni added a comment. Herald added a subscriber: ThomasRaoux. Herald added a reviewer: zuban32. Herald added a reviewer: mpaszkowski. - Rebase and fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT/VT

2023-04-19 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni created this revision. Herald added subscribers: luke, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, ormris, foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, atanasyan,