This revision was automatically updated to reflect the committed changes.
TIFitis marked 2 inline comments as done.
Closed by commit rG35309db7dcef: [OpenMP][OMPIRBuilder] Migrate
MapCombinedInfoTy from Clang to OpenMPIRBuilder (authored by TIFitis).
Repository:
rG LLVM Github Monorepo
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149666/new/
https://reviews.llvm.org/D149666
TIFitis marked 2 inline comments as done.
TIFitis added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6848
+ class MapCombinedInfoTy : public llvm::OpenMPIRBuilder::MapCombinedInfoTy {
+ public:
MapExprsArrayTy Exprs;
jdoerfert wrote:
TIFitis updated this revision to Diff 519054.
TIFitis added a comment.
Changed name from llvm::OpenMPIRBuilder::MapCombinedInfoTy to
llvm::OpenMPIRBuilder::MapInfosTy, and changed to struct instead of class.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6848
+ class MapCombinedInfoTy : public llvm::OpenMPIRBuilder::MapCombinedInfoTy {
+ public:
MapExprsArrayTy Exprs;
TIFitis wrote:
> jdoerfert wrote:
> > Not sure why you
TIFitis updated this revision to Diff 518847.
TIFitis marked 2 inline comments as done.
TIFitis added a comment.
Merged MapDevPtrsArrayTy and MapMappersArrayTy into single type named
MapValueDeclsArrayTy in CGOpenMPRuntime.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
TIFitis marked 2 inline comments as done.
TIFitis added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6848
+ class MapCombinedInfoTy : public llvm::OpenMPIRBuilder::MapCombinedInfoTy {
+ public:
MapExprsArrayTy Exprs;
jdoerfert wrote:
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6848
+ class MapCombinedInfoTy : public llvm::OpenMPIRBuilder::MapCombinedInfoTy {
+ public:
MapExprsArrayTy Exprs;
Not sure why you made it a class with public, but I
TIFitis created this revision.
TIFitis added reviewers: jsjodin, jdoerfert, dpalermo.
Herald added subscribers: sunshaoce, guansong, yaxunl.
Herald added a project: All.
TIFitis requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1.
Herald added
