[PATCH] D150450: Add C++26 compile flags.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb763d6a4ed46: Add C++26 compile flags. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150450: Add C++26 compile flags.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you Erich! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 522214. erichkeane added a comment. change __cplusplus to match GCC's plan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst clang/docs/ReleaseNotes.rst

[PATCH] D150450: Add C++26 compile flags.

erichkeane added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:456 + // FIXME: Use correct value for C++26. + Builder.defineMacro("__cplusplus", "202402L"); +else if (LangOpts.CPlusPlus23) erichkeane wrote: > aaron.ballman

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 522199. erichkeane added a comment. Aarons comments, split 23 changes into a separate patch and rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D150450: Add C++26 compile flags.

Mordante added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions erichkeane wrote: > aaron.ballman wrote: > > We shouldn't call it

[PATCH] D150450: Add C++26 compile flags.

erichkeane marked 8 inline comments as done. erichkeane added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions aaron.ballman

[PATCH] D150450: Add C++26 compile flags.

aaron.ballman added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions We shouldn't call it `ISO C++ 2026` until it's published by

[PATCH] D150450: Add C++26 compile flags.

xbolva00 added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:458 +else if (LangOpts.CPlusPlus23) + Builder.defineMacro("__cplusplus", "202302L"); // [C++20] The integer literal 202002L. Separate patch / commit? CHANGES

[PATCH] D150450: Add C++26 compile flags.

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1568 +C++2c implementation status + h-vetinari wrote: > The longer this page gets, the more I feel it should be sorted in reverse > chronological order of the standard versions. It's

[PATCH] D150450: Add C++26 compile flags.

shafik added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6649 .Case("c++20", "-std=c++20") // TODO add c++23 when MSVC supports it. + .Case("c++latest", "-std=c++26")

[PATCH] D150450: Add C++26 compile flags.

h-vetinari added inline comments. Comment at: clang/include/clang/Basic/LangStandard.h:128 + + // hasDigraphs - Language supports digraphs. bool hasDigraphs() const { return Flags & Digraphs; } Spuriously removed slash Comment at:

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 521743. erichkeane marked an inline comment as done. erichkeane added a comment. Added double-backticks, updated the tests for the new __cplusplus entries I changed during review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/

[PATCH] D150450: Add C++26 compile flags.

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:114 +^ +- Compiler flags -std=c++2c and -std=gnu++2c have been added for experimental C++26 implementation work. + cor3ntin wrote: > This

[PATCH] D150450: Add C++26 compile flags.

cor3ntin accepted this revision. cor3ntin added a comment. LGTM. I'm looking forward to start implementing upcoming proposals CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 ___ cfe-commits mailing

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 521688. erichkeane added a comment. Updated last few things @Mordante mentioned, did a rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D150450: Add C++26 compile flags.

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. In D150450#4338065 , @erichkeane wrote: > In D150450#4338034 , @Mordante > wrote: > >> In

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 521680. erichkeane added a comment. Added clang-cl versioning as stolen from @Mordante CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D150450: Add C++26 compile flags.

erichkeane added a comment. In D150450#4338034 , @Mordante wrote: > In D150450#4337952 , @erichkeane > wrote: > >> In D150450#4337858 , @cor3ntin >> wrote: >> >>>

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 521675. erichkeane marked an inline comment as done. erichkeane added a comment. fix init-preprocessor, remove fixme. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files:

[PATCH] D150450: Add C++26 compile flags.

Mordante added a comment. In D150450#4337952 , @erichkeane wrote: > In D150450#4337858 , @cor3ntin > wrote: > >> Similar PR here https://reviews.llvm.org/D149875 > > Ah! I'd not noticed that one (or maybe

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 521661. erichkeane added a comment. Update based on @cor3ntin s feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst clang/docs/ReleaseNotes.rst

[PATCH] D150450: Add C++26 compile flags.

erichkeane marked 4 inline comments as done. erichkeane added a subscriber: Mordante. erichkeane added a comment. In D150450#4337858 , @cor3ntin wrote: > Similar PR here https://reviews.llvm.org/D149875 Ah! I'd not noticed that one (or maybe someone

[PATCH] D150450: Add C++26 compile flags.

cor3ntin added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:456 + // FIXME: Use correct value for C++26. + Builder.defineMacro("__cplusplus", "202102L"); +// FIXME: Use correct value for C++23, and update C++26 to be 'one more'.

[PATCH] D150450: Add C++26 compile flags.

cor3ntin added a comment. Similar PR here https://reviews.llvm.org/D149875 Comment at: clang/docs/ReleaseNotes.rst:114 +^ +- Compiler flags -std=c++2c and -std=gnu++2c have been added for experimental C++26 implementation work. + This

[PATCH] D150450: Add C++26 compile flags.

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:310 DiagGroup<"pre-c++23-compat-pedantic", [CXXPre23Compat]>; +def CXXPre26Compat : DiagGroup<"pre-c++26-compat">; +def CXXPre26CompatPedantic : Aaron: note the names

[PATCH] D150450: Add C++26 compile flags.

erichkeane created this revision. erichkeane added reviewers: clang-language-wg, aaron.ballman. Herald added a project: All. erichkeane requested review of this revision. Herald added a subscriber: MaskRay. Now that we've updated to C++23, we need to add C++26/C++2c command line flags, as