[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

This revision was automatically updated to reflect the committed changes. Closed by commit rG91be60b34715: Respect -fdiagnostics-absolute-paths on emit include location (authored by charmitro, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

cjdb added a comment. I already have another commit I plan to push, will do these together :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4396008 , @charmitro wrote: > In D151833#4395956 , @aaron.ballman > wrote: > >> Do you need someone to commit on your behalf? If so, what name and email >> address would

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4396426 , @cjdb wrote: > In D151833#4396399 , @charmitro > wrote: > >> In D151833#4396244 , @cjdb wrote: >> >>> Can the commit

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

cjdb added a comment. In D151833#4396399 , @charmitro wrote: > In D151833#4396244 , @cjdb wrote: > >> Can the commit message have a description please? It's unclear to me why >> this is necessary (although I'm

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4396244 , @cjdb wrote: > Can the commit message have a description please? It's unclear to me why this > is necessary (although I'm sure there's a good reason). Thanks! Done, also check

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

cjdb added a comment. Can the commit message have a description please? It's unclear to me why this is necessary (although I'm sure there's a good reason). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro marked an inline comment as done. charmitro added a comment. In D151833#4395956 , @aaron.ballman wrote: > Do you need someone to commit on your behalf? If so, what name and email > address would you like used for patch attribution? In

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added a comment. @charmitro do you have commit rights or do you need someone to push on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___ cfe-commits mailing list

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

aaron.ballman added a comment. Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___ cfe-commits mailing

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added subscribers: cjdb, aaron.ballman. tbaeder added a comment. LGTM, but maybe wait for a response from @aaron.ballman or @cjdb CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 528219. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index:

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: charmitro wrote: > tbaeder wrote: > > charmitro wrote: > > >

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > charmitro wrote: > > tbaeder wrote: > > >

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: charmitro wrote: > tbaeder wrote: > > charmitro wrote: > > >

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527914. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index:

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > charmitro wrote: > > tbaeder wrote: > > > This

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: charmitro wrote: > tbaeder wrote: > > This checks the same thing

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > This checks the same thing in both cases, but

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: This checks the same thing in both cases, but in the `NORMAL`

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527828. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index:

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4390279 , @charmitro wrote: > In D151833#4386128 , @tbaeder wrote: > >> Can you add a test case for the change? Looks like there's something similar >> already in

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527821. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index:

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4386128 , @tbaeder wrote: > Can you add a test case for the change? Looks like there's something similar > already in `clang/test/Frontend/absolute-paths.c` Is it possible to use substitutions inside let's say

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added a comment. Can you add a test case for the change? Looks like there's something similar already in `clang/test/Frontend/absolute-paths.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. charmitro requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Charalampos Mitrodimas Repository: rG LLVM Github