[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

This revision was automatically updated to reflect the committed changes. Closed by commit rG409a8097c5c7: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes (authored by hazohelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

hazohelet added a comment. In D153267#4445417 , @cjdb wrote: > Thanks! This LGTM now. Do you need assistance with merging? Thanks for the review! I have commit access now, so I'll be landing this myself. CHANGES SINCE LAST ACTION

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

cjdb accepted this revision. cjdb added a comment. Thanks! This LGTM now. Do you need assistance with merging? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153267/new/ https://reviews.llvm.org/D153267 ___ cfe-commits mailing list

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

hazohelet updated this revision to Diff 533971. hazohelet marked an inline comment as done. hazohelet edited the summary of this revision. hazohelet added a comment. Address comments from @cjdb and @aaron.ballman - Remove unnecessary cast to void in test - Add release note CHANGES SINCE LAST

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM modulo Chris' comment, but can you please add a release note for the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

cjdb added a comment. I think this will be a good addition because it underscores the salient part of why the function isn't viable. Would it be possible for patches like this to have both examples of before and after this patch in their commit message please? That'll help expose why patches

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

tbaeder added a comment. LGTM but let's wait for a second opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153267/new/ https://reviews.llvm.org/D153267 ___ cfe-commits mailing list

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb, erichkeane. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. On mismatch of arity of functions like void func( int aa, int bb) {} void callsite()