[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. In D153366#4471460 , @sammccall wrote: > In D153366#4471320 , @TWeaver wrote: > >> My apologies but I've had to revert this change for now until the author can >> address the buildbot

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added a comment. In D153366#4471320 , @TWeaver wrote: > My apologies but I've had to revert this change for now until the author can > address the buildbot failures. Thanks for the revert, and sorry for the disruption - I expected to be

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. My apologies but I've had to revert this change for now until the author can address the buildbot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. Hello and good afternoon from the UK, I believe this change has introduced test failures on the following buildbot: https://lab.llvm.org/buildbot/#/builders/139/builds/44269 are you able to take a look see? Much appreciated, Tom W Repository: rG LLVM Github

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/80815/step_7.txt Please take a look etc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

uabelho added a comment. Failed Tests (6): Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/BoolValueDebugStringTest/ComplexBooleanWithSomeNames Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/BoolValueDebugStringTest/Conjunction

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG2fd614efc1bb: [dataflow] Add dedicated representation of boolean formulas (authored by sammccall).

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall marked 11 inline comments as done. sammccall added inline comments. Herald added a subscriber: wangpc. Comment at: clang/include/clang/Analysis/FlowSensitive/Formula.h:69 + + Atom atom() const { +assert(kind() == AtomRef); gribozavr2 wrote: >

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Formula.h:27 +/// +/// This often represents an assertion that is interesting to the analysis but +///

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 535491. sammccall added a comment. rebase, primarily on the SAT-inputs-are-ordered change (SetVector etc) clarify that Formula::print output is supposed to be reliably stable. This is useful for testing downstream analyses: having a representation of

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added a comment. BTW, since this is a substantial API/concept change, I'll wait on approval from all of @mboehme, @xazax.hun, @gribozavr2 - if you don't plan to review just LMK. (Not in a hurry, just wanted to mention so we don't deadlock :-) Comment at:

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 534117. sammccall marked 10 inline comments as done. sammccall added a comment. address Martin's review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

mboehme added a comment. In D153366#4441758 , @sammccall wrote: >> Would you like me to review https://reviews.llvm.org/D153469 or should we >> wait for this patch to converge first? > > Similarly it'd be great to get high-level feedback there: whether

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added a comment. > Would you like me to review https://reviews.llvm.org/D153469 or should we > wait for this patch to converge first? Similarly it'd be great to get high-level feedback there: whether the design of FormulaBoolValue is right, whether the changes to use Atom/Formula

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

mboehme added a comment. High-level comment: I like the separation of concerns that this introduces. Would you like me to review https://reviews.llvm.org/D153469 or should we wait for this patch to converge first? Comment at:

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added reviewers: gribozavr2, xazax.hun, mboehme. sammccall added a comment. Splitting out Formula from BoolValue is a pretty big change... I've tried to keep this patch a manageable size by really just using Formula for interacting with the SAT solver and some printing, but this means

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533029. sammccall added a comment. clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/clang/Analysis/FlowSensitive/Arena.h

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533028. sammccall added a comment. remove dead comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/clang/Analysis/FlowSensitive/Arena.h

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533027. sammccall edited the summary of this revision. sammccall added a comment. more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files:

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533025. sammccall edited the summary of this revision. sammccall added a comment. updating description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files:

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall updated this revision to Diff 533022. sammccall added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 Files: clang/include/clang/Analysis/FlowSensitive/Arena.h

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall created this revision. Herald added subscribers: martong, mgrang, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is the first step in