[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

nridge abandoned this revision. nridge added a comment. Abandoning in favour of D155381 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153946/new/ https://reviews.llvm.org/D153946

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

sammccall added a comment. In D153946#4521576 , @nridge wrote: > Yeah, I'm happy to go with D155381 instead. > > In D153946#4503585 , @sammccall > wrote: > >> (Stupid

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

nridge added a comment. Yeah, I'm happy to go with D155381 instead. In D153946#4503585 , @sammccall wrote: > (Stupid over-flexible config system is too slow... I've learned my lesson > from that one!) The issues with

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

sammccall added a comment. In D153946#4503585 , @sammccall wrote: > - maybe we can come up with some heuristics to improve the "no reserved > names" rule, with or without configuration. (Maybe apply it to only -isystem > headers? Linux uses

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

sammccall added a comment. Thanks for putting this together, it definitely seems like something people want. My main concern is that the configuration has the wrong scope. We're checking whether reserved-ident indexing is on for the **TU** we're indexing, but really we want to specify which

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

nridge added a comment. No tests yet, posting for early feedback. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:233 IndexOpts.StoreAllDocumentation = true; + // FIXME: Should we respect the Index.ReservedIdentifiers config here? // Sadly we can't use

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

nridge created this revision. nridge added reviewers: hokein, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Some