aaron.ballman added inline comments.
Comment at: clang/lib/Lex/Preprocessor.cpp:998
+std::vector Preprocessor::LexAll() {
+ std::vector toks;
v.g.vassilev wrote:
> Shouldn't we take the results as a `LexAll(std::vector )`?
>
> Perhaps we should rename this
v.g.vassilev added inline comments.
Comment at: clang/lib/Lex/Preprocessor.cpp:998
+std::vector Preprocessor::LexAll() {
+ std::vector toks;
Shouldn't we take the results as a `LexAll(std::vector )`?
Perhaps we should rename this interface to
Hahnfeld added a comment.
ping!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158413/new/
https://reviews.llvm.org/D158413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hahnfeld added a comment.
ping :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158413/new/
https://reviews.llvm.org/D158413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hahnfeld created this revision.
Hahnfeld added reviewers: hokein, aaron.ballman.
Herald added subscribers: kbarton, nemanjai.
Herald added a project: All.
Hahnfeld requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This new method repeatedly
