[PATCH] D158572: [clang][modules] Use relative offsets for input files

phosek added a comment. In D158572#4615234 , @phosek wrote: > In D158572#4615231 , @jansvoboda11 > wrote: > >> @phosek BTW can you confirm whether these started failing with this patch or >> with D158573

[PATCH] D158572: [clang][modules] Use relative offsets for input files

phosek added a comment. In D158572#4615231 , @jansvoboda11 wrote: > @phosek BTW can you confirm whether these started failing with this patch or > with D158573 ? I'm trying to do a local build now to find out.

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 added a comment. @phosek BTW can you confirm whether these started failing with this patch or with D158573 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158572/new/ https://reviews.llvm.org/D158572

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 added a comment. In D158572#4615198 , @phosek wrote: > After this change, all libc++ `clang_modules_include.gen.py` tests started > failing on our Linux builders: > > ... > > You can see the full output at >

[PATCH] D158572: [clang][modules] Use relative offsets for input files

phosek added a comment. After this change, all libc++ `clang_modules_include.gen.py` tests started failing on our Linux builders: Script: -- : 'COMPILED WITH'; /b/s/w/ir/x/w/llvm_build/./bin/clang++

[PATCH] D158572: [clang][modules] Use relative offsets for input files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d78bdc730b: [clang][modules] Use relative offsets for input files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 updated this revision to Diff 552894. jansvoboda11 added a comment. Initialize absolute offsets in `ASTReader`/`ModuleFile`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158572/new/ https://reviews.llvm.org/D158572 Files:

[PATCH] D158572: [clang][modules] Use relative offsets for input files

benlangmuir added inline comments. Comment at: clang/include/clang/Serialization/ModuleFile.h:249 + /// Absolute offset of the start of the input-files block. + uint64_t InputFilesOffsetBase; + jansvoboda11 wrote: > benlangmuir wrote: > > Doesn't

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 added inline comments. Comment at: clang/include/clang/Serialization/ModuleFile.h:249 + /// Absolute offset of the start of the input-files block. + uint64_t InputFilesOffsetBase; + benlangmuir wrote: > Doesn't `InputFilesCursor` already know

[PATCH] D158572: [clang][modules] Use relative offsets for input files

benlangmuir added inline comments. Comment at: clang/include/clang/Serialization/ModuleFile.h:249 + /// Absolute offset of the start of the input-files block. + uint64_t InputFilesOffsetBase; + Doesn't `InputFilesCursor` already know where the input files

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch replaces absolute