[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL closed this revision. PiotrZSL added a comment. Obsolete. No longer needed after D159436 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159045/new/ https://reviews.llvm.org/D159045

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL added a comment. In D159045#4631820 , @felix642 wrote: > In that case, I agree with you, it would be helpful to add this feature. I > think supporting an empty value rather than a boolean is preferable. We > should maybe do that in another

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 added a comment. In that case, I agree with you, it would be helpful to add this feature. I think supporting an empty value rather than a boolean is preferable. We should maybe do that in another Differential though. I can open an issue on github and I'll open another diff when I'm

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL added a comment. In D159045#4631650 , @felix642 wrote: > We can already disable those options if we don't define them in the config. > Adding the possibility to provide optional values seems redundant to me. Do > you see any reason why we

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 added a comment. We can already disable those options if we don't define them in the config. Adding the possibility to provide optional values seems redundant to me. Do you see any reason why we would absolutely need to add this option to the config if we want to disable it?

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Change is ok. Interesting thing is that we got more of such issues in many checks. I'm thinking, maybe support for optional fields is needed, fields that can accept integer or false/no

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 updated this revision to Diff 554124. felix642 added a comment. Linked issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159045/new/ https://reviews.llvm.org/D159045 Files:

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 updated this revision to Diff 554122. felix642 added a comment. Fixed commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159045/new/ https://reviews.llvm.org/D159045 Files:

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The