[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

Myrronth added a comment. Thanks, I’ll give it a try. https://reviews.llvm.org/D17700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther added a comment. My fork of spacecommander has a version of clang-format with the option. It's a couple of years old at this point, but it has been running without any issues. https://reviews.llvm.org/D17700 ___ cfe-commits mailing list

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

Myrronth added a comment. Do you mind sharing your modified version? The fork in the discussion you mentioned (https://github.com/square/spacecommander/issues/33) seems to be out-of-date or at least does not have the AllowNewlineBeforeBlockParameter setting. https://reviews.llvm.org/D17700

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther added a comment. It seems to have been. I've been using a modified version of clang-format with this change applied (as well as http://reviews.llvm.org/D17922) since I submitted this. https://reviews.llvm.org/D17700 ___ cfe-commits

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

dcasadevall added a comment. Was this lost in the woods? I believe this is a valid change when working in Objective-C https://reviews.llvm.org/D17700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

tonyarnold added a comment. > Blocks aren't the same as braces Yeah, good point. I guess I was just seeing the brace in the block, but that's the wrong way to think about it. http://reviews.llvm.org/D17700 ___ cfe-commits mailing list

Re: [PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther updated this revision to Diff 49928. ksuther added a comment. Thanks for the comments. I've made some changes that eliminates reverting r236598 and instead makes the behavior part of `IndentNestedBlocks`. That allows the Google Obj-C code style

Re: [PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

tonyarnold added a comment. Aside from the lack of tests, and `AllowNewlineBeforeBlockParameter` being outside of `BraceWrapping`, this is good! Much closer to how Apple's documentation and Xcode format blocks!  Comment at: include/clang/Format/Format.h:421 @@ +420,3 @@ +

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther created this revision. ksuther added a reviewer: djasper. ksuther added a subscriber: cfe-commits. Herald added a subscriber: klimek. Changes to clang-format's Objective-C block formatting over the past year have made clang-format's output deviate from what is expected (in my opinion).