Eugene.Zelenko added a comment.
Please see PR28836. In some cases check should recommend to use insert().
Repository:
rL LLVM
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277677: [clang-tidy] Inefficient string operation (authored
by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D20196?vs=66492&id=66730#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Prazek added a comment.
In https://reviews.llvm.org/D20196#504397, @bittnerbarni wrote:
> I'm planning to submit more patches in the future, as I have time for them.
> So it wouldn't be in vain :)
http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
https://reviews.llvm.org/D201
bittnerbarni added a comment.
I'm planning to submit more patches in the future, as I have time for them. So
it wouldn't be in vain :)
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Prazek added a subscriber: Prazek.
Prazek added a comment.
In https://reviews.llvm.org/D20196#504394, @bittnerbarni wrote:
> Thank you for all the assistance. Could you please do that?
btw obtaining commit access and commiting is very simple, so if you are
planning to send us some more cool pa
bittnerbarni added a comment.
Thank you for all the assistance. Could you please do that?
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you for working on this!
Do you need me to commit the patch for you?
https://reviews.llvm.org/D20196
___
cfe-commits mailing l
bittnerbarni marked 14 inline comments as done.
bittnerbarni added a comment.
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bittnerbarni updated this revision to Diff 66492.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidy
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Sorry for the delay. I almost missed that there was an update to the patch.
Please mark addressed comments as "Done". This way it's easier for me to track
changes and it's easier for
bittnerbarni updated this revision to Diff 65606.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidy
alexfh added a comment.
A couple of nits.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:51
@@ +50,3 @@
+ hasArgument(
+ 0, declRefExpr(BasicStringType),
+ declRefExpr(hasDeclaration(decl().bind("lhsStrT"))).bind("lhsStr")),
---
bittnerbarni added inline comments.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:55
@@ +54,3 @@
+ hasDeclaration(decl(equalsBoundNode("lhsStrT"))),
+ hasDescendant(BasicStringPlusOperator));
+
Yes this
bittnerbarni updated this revision to Diff 65384.
bittnerbarni marked an inline comment as done.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationC
alexfh added a comment.
A few more nits.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:50
@@ +49,3 @@
+ hasOverloadedOperatorName("="),
+ hasArgument(0, allOf(declRefExpr(BasicStringType),
+ declRefExpr(hasDeclarat
bittnerbarni updated this revision to Diff 63098.
bittnerbarni added a comment.
Thank you, for your valuable comments Alexander!
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performanc
alexfh added inline comments.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:50
@@ +49,3 @@
+ hasOverloadedOperatorName("="), hasDescendant(BasicStringPlusOperator),
+ allOf(hasArgument(
+0, allOf(declRefExpr(BasicStringType),
bittnerbarni updated this revision to Diff 61893.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidyM
bittnerbarni added inline comments.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:67
@@ +66,3 @@
+Finder->addMatcher(
+exprWithCleanups(anyOf(hasDescendant(AssingOperator),
+ hasDescendant(PlusOperatorMatcher))
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:41
@@ +40,3 @@
+
+ const auto PlusOperatorMatcher =
+ cxxOperatorCallExpr(
s/Matcher//
=
bittnerbarni updated this revision to Diff 59661.
bittnerbarni marked 6 inline comments as done.
bittnerbarni added a comment.
Removed the unnecessary hasDescendant calls and simplified the checker as
suggested. Tested on LLVM codebase, with minor improvements in speed (~1%).
http://reviews.llv
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:31
@@ +30,3 @@
+MatchFinder *Finder) {
+ if (!getLangOpts().CPlusPlus) return;
+
clang-format
bittnerbarni updated this revision to Diff 58054.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidyM
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:28
@@ +27,3 @@
+: ClangTidyCheck(Name, Context),
+ IsStrictMode(Options.get("isStrictMode", 0)) {}
+
---
bittnerbarni updated this revision to Diff 57894.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringAdditionCheck.cpp
clang-tidy/performance/InefficientStringAdditionCheck.h
clang-tidy/performance/PerformanceTidyModule.cpp
alexfh added a comment.
Please create a diff with the full context:
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:84
@@ +83,3 @@
+ const auto DiagMsg =
+ "Inefficient s
bittnerbarni updated this revision to Diff 57346.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringAdditionCheck.cpp
clang-tidy/performance/InefficientStringAdditionCheck.h
clang-tidy/performance/PerformanceTidyModule.cpp
etienneb added inline comments.
Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:35
@@ +34,3 @@
+
cxxOperatorCallExpr(hasAnyArgument(ignoringImpCasts(declRefExpr(BasicStringType))),
+ hasOverloadedOperatorName("+"));
+
--
bittnerbarni updated this revision to Diff 57294.
bittnerbarni added a comment.
Sorry for uploading 2 line long diffs. I uploaded the whole diff now.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringAdditionCheck.cpp
clang
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
The last diff has nothing but a 2-line change in the docs.
http://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@list
bittnerbarni updated this revision to Diff 57181.
http://reviews.llvm.org/D20196
Files:
docs/clang-tidy/checks/performance-inefficient-string-addition.rst
Index: docs/clang-tidy/checks/performance-inefficient-string-addition.rst
=
bittnerbarni updated this revision to Diff 57185.
http://reviews.llvm.org/D20196
Files:
docs/clang-tidy/checks/performance-inefficient-string-addition.rst
Index: docs/clang-tidy/checks/performance-inefficient-string-addition.rst
=
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:191
@@ +190,3 @@
+ This check is to warn about the performance overhead arising from
concatenating
+ strings, using the operator+, instead of operator+=.
+
Please highlight operator+ and
bittnerbarni updated this revision to Diff 57172.
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/InefficientStringAdditionCheck.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/checks/performance-inefficient-string-addition.rst
test/clang-tidy/performance-inefficient-string-additio
etienneb added a subscriber: etienneb.
etienneb added a comment.
drive-by, some nits.
Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:31
@@ +30,3 @@
+void InefficientStringAdditionCheck::registerMatchers(MatchFinder *Finder) {
+ auto BasicStringType =
has
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/performance-inefficient-string-addition.rst:8
@@ +7,3 @@
+--
+This ch
36 matches
Mail list logo
