Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-08 Thread Christof Douma via cfe-commits
christof added a comment. In http://reviews.llvm.org/D21082#451393, @kubabrecka wrote: > This doesn’t make sense to me, Clang is able to produce ASanified code even > when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER > does). Where exactly is this test failing? Right.

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. http://reviews.llvm.org/D21117 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Oh, I see, most asan tests in clang use cross-compiler, e.g.: -target x86_64-linux-gnu Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. It was accepted accidentally. Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Actually there are other tests with -fsanitize=address I see only difference in %clang vs %clang_cc1? Could you try this? Repository: rL LLVM http://reviews.llvm.org/D21082

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. I guess you can remove // UNSUPPORTED: mingw32 added by cfe/trunk@271509 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Kuba Brecka via cfe-commits
kubabrecka added a subscriber: kubabrecka. kubabrecka added a comment. This doesn’t make sense to me, Clang is able to produce ASanified code even when the compiler itself isn’t ASanified (that’s what LLVM_USE_SANITIZER does). Where exactly is this test failing? Repository: rL LLVM

[PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Christof Douma via cfe-commits
christof created this revision. christof added reviewers: vitalybuka, chapuni. christof added a subscriber: cfe-commits. christof set the repository for this revision to rL LLVM. The asan tests should only run on builds that have LLVM_USE_SANITIZER set. The feature 'asan' reflects this and is