[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

sylvestre.ledru added a comment. In D24243#1695052 , @sylvestre.ledru wrote: > Maybe it could be mentioned in the release notes? Forget about this comment, I have been distracted by the fact that it is now installed https://reviews.llvm.org/D68423 Re

[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

sylvestre.ledru added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Maybe it could be mentioned in the release notes? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24243/new/ https://reviews.llvm.org/D24243 __

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282070: [clang-move] A prototype tool for moving class definition to new file. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D24243?vs=72031&id=72033#toc Repository: rL LLVM

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 72031. hokein added a comment. Improve the way of detecting whether #include in old_header. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.t

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 72027. hokein added a comment. Update dependency. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.txt clang-move/tool/ClangMoveMain.cpp u

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 71631. hokein added a comment. Support fully quailified name only. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.txt clang-move/tool/Clan

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg Comment at: unittests/clang-move/ClangMoveTests.cpp:122 @@ +121,3 @@ + +const char ExpectedNewCC[] = "#include \"foo.h\"\n" + "namespace a {\n"

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:104 @@ +103,3 @@ + std::reverse(Namespaces.begin(), Namespaces.end()); + return Namespaces; +} Aha, I see. I misused the `findLocationAfterToken` previously. Comment at: clang-m

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 71506. hokein marked 2 inline comments as done. hokein added a comment. Herald added a subscriber: mgorny. Address review comments. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/Cl

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:103 @@ +102,3 @@ + const clang::SourceManager *SM) { + // Gets the ending ";". + auto EndLoc = clang::Lexer::getLocForEndOfToken(D->getLocEnd(), 0, *SM, hokein

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 70538. hokein marked 19 inline comments as done. hokein added a comment. Herald added a subscriber: beanz. - Address review comments. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:38 @@ +37,3 @@ + const clang::Module * /*Imported*/) override { +if (const auto *FileEntry = SM.getFileEntryForID(SM.getFileID(HashLoc))) { + if (IsAngled) { ioeri

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

ioeric added a comment. NIce! Some initial comments. Comment at: clang-move/ClangMove.cpp:38 @@ +37,3 @@ + const clang::Module * /*Imported*/) override { +if (const auto *FileEntry = SM.getFileEntryForID(SM.getFileID(HashLoc))) { + if (IsAngled)

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

Eugene.Zelenko added a comment. Probably old_source/new_source will be better, because different extensions are used for C++ files. https://reviews.llvm.org/D24243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

Eugene.Zelenko added inline comments. Comment at: clang-move/ClangMove.h:13 @@ +12,3 @@ + +#include +#include Isn't C++ headers should be after Clang headers? https://reviews.llvm.org/D24243 ___ cfe-commits mailin

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: clang-move/ClangMove.h:33 @@ +32,3 @@ +clang::SourceManager *SM; +MovedDecl() : Decl(nullptr), SM(nullptr) {} +MovedDecl(const clang::Decl *Decl, clang::SourceManager *SM) Please add empty

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

omtcyfz added inline comments. Comment at: clang-move/ClangMove.h:25 @@ +24,3 @@ + +// TODO(hokein): Make it support more types, e.g. function definitions. +// Currently only support moving class definition. `FIXME`? https://reviews.llvm.org/D24243 __

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 70363. hokein added a comment. Fix function name style. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.txt clang-move/tool/ClangMoveMain.c

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein updated this revision to Diff 70362. hokein added a comment. Minor cleanup. https://reviews.llvm.org/D24243 Files: CMakeLists.txt clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/CMakeLists.txt clang-move/tool/ClangMoveMain.cpp unitt

[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

hokein created this revision. hokein added a subscriber: cfe-commits. This patch introduces a new tool which moves a specific class definition from files (.h, .cc) to new files (.h, .cc), which mostly acts like "Extract class defintion". In the long term, this tool should be merged in to clang-ref