Re: [PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

2016-09-16 Thread Shoaib Meenai via cfe-commits
smeenai added a subscriber: smeenai. Comment at: docs/DesignDocs/VisibilityMacros.rst:33 @@ +32,3 @@ + Mark a type's typeinfo and vtable as having default visibility. + `_LIBCPP_TYPE_VIS`. This macro has no effect on the visibility of the + type's member functions. This attribu

Re: [PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 71570. EricWF added a comment. I'm going to go ahead and commit this w/o review because it's blocking more important changes. Post-commit comments on the documentation are appreciated. https://reviews.llvm.org/D24602 Files: CMakeLists.txt docs/DesignDoc

Re: [PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: include/__config:605 @@ +604,3 @@ +# if __has_attribute(__type_visibility__) +#define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS __attribute__ ((__visibility__("default"))) +# else Checking `__type_visibility__` and using `__

Re: [PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 71486. EricWF added a comment. Fix obvious errors in docs. https://reviews.llvm.org/D24602 Files: CMakeLists.txt docs/DesignDocs/VisibilityMacros.rst docs/index.rst include/__config include/__locale include/__string include/experimental/filesys

[PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. This patch fixes a number of problems with the visibility macros across GCC (on Unix) and Windows (DLL import/export semantics). All of the visibili