This revision was automatically updated to reflect the committed changes.
Closed by commit rL284651: DebugInfo: use uint32_t for alignment variables.
(authored by vleschuk).
Changed prior to commit:
https://reviews.llvm.org/D25621?vs=75143=75241#toc
Repository:
rL LLVM
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thanks, this LGTM!
https://reviews.llvm.org/D25621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vleschuk added a comment.
In https://reviews.llvm.org/D25621#573671, @aprantl wrote:
> This patch is conflating two set of changes:
> (1) NFC: rename all occurrences of unsigned for alignment purposes in the
> frontend with uint32_t
> (2) shrink all debug-info-related alignment variables from
vleschuk updated this revision to Diff 75143.
vleschuk added a comment.
- Removed all changes non-related to CGDebugInfo: will post them in separate
NFC patch which will switch all unsigned alignment entries to uint32_t.
https://reviews.llvm.org/D25621
Files:
lib/CodeGen/CGDebugInfo.cpp
aprantl added a comment.
This patch is conflating two set of changes:
(1) NFC: rename all occurrences of unsigned for alignment purposes in the
frontend with uint32_t
(2) shrink all debug-info-related alignment variables from uint64_t ->
unint32_t.
I think this patch should only be doing the
vleschuk added a comment.
Can anyone take a look at this please? =)
https://reviews.llvm.org/D25621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
