[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

2016-11-15 Thread Michał Górny via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286952: [test] Correctly include build llvm_shlib_dir in stand-alone builds (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D26115?vs=76296=77982#toc Repository: rL LLVM

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

2016-11-14 Thread Chris Bieneman via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/lit.cfg:109 +if not llvm_shlib_dir: +lit_config.fatal('No LLVM shlib dir set!') llvm_libs_dir = getattr(config, 'llvm_libs_dir', None)

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

2016-11-14 Thread Michał Górny via cfe-commits
mgorny added inline comments. Comment at: test/lit.cfg:109 +if not llvm_shlib_dir: +lit_config.fatal('No LLVM shlib dir set!') llvm_libs_dir = getattr(config, 'llvm_libs_dir', None) beanz wrote: > Should this really be fatal? It seems to me in

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

2016-11-14 Thread Chris Bieneman via cfe-commits
beanz added inline comments. Comment at: test/lit.cfg:109 +if not llvm_shlib_dir: +lit_config.fatal('No LLVM shlib dir set!') llvm_libs_dir = getattr(config, 'llvm_libs_dir', None) Should this really be fatal? It seems to me in many cases you

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

2016-11-11 Thread Michał Górny via cfe-commits
mgorny added a comment. Ping. https://reviews.llvm.org/D26115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

2016-10-29 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: ddunbar, beanz. mgorny added a subscriber: cfe-commits. Add the build llvm_shlib_dir into LD_LIBRARY_PATH before the directory specified as llvm_libs_dir, in order to fix stand-alone builds attempting to use installed clang libraries. In case