jordan_rose closed this revision.
jordan_rose added a comment.
Landed as-is in https://reviews.llvm.org/rL292571.
Repository:
rL LLVM
https://reviews.llvm.org/D28924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added a comment.
In https://reviews.llvm.org/D28924#651139, @jordan_rose wrote:
> Interestingly, this case doesn't actually work yet; we unconditionally print
> enum attributes after the close-brace even though that's not valid for C++
> attributes. Do you think I should change
jordan_rose added a comment.
Interestingly, this case doesn't actually work yet; we unconditionally print
enum attributes after the close-brace even though that's not valid for C++
attributes. Do you think I should change that as well, or just land this patch
as is?
Repository:
rL LLVM
jordan_rose added a comment.
Good idea, will do.
Repository:
rL LLVM
https://reviews.llvm.org/D28924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, though if you wanted to add one more test with a C++ attribute
(deprecated would work in C++14 mode), that would not make me sad. Something
like:
enum [[deprecated]] E
jordan_rose created this revision.
The AST printer was dropping attributes on enumerators (enum constants). Now
it's not.
Repository:
rL LLVM
https://reviews.llvm.org/D28924
Files:
lib/AST/DeclPrinter.cpp
test/Sema/ast-print.c
Index: test/Sema/ast-print.c
