bcraig added a comment.
In https://reviews.llvm.org/D32411#1056381, @EricWF wrote:
> I spoke to STL on the MSVC team a while ago, and he stated that if we
> produced a paper describing why we need `#include_next` and the rational
> behind it, and they would pass that on to the front-end team.
EricWF added a comment.
Herald added a subscriber: christof.
I spoke to STL on the MSVC team a while ago, and he stated that if we produced
a paper describing why we need `#include_next` and the rational behind it, and
they would pass that on to the front-end team. They didn't guarantee that
bcraig updated this revision to Diff 126275.
bcraig added a comment.
Rebased
https://reviews.llvm.org/D32411
Files:
CMakeLists.txt
docs/DesignDocs/IncludeNextEmulation.rst
include/__config
include/__config_site.in
include/complex.h
include/cstddef
include/ctype.h
bcraig added a comment.
Talked with mclow and some Microsoft devs in Albuquerque. I'm not expecting
include_next to show up in MSVC. Sometime in the next month I hope to rebase
this change.
https://reviews.llvm.org/D32411
___
cfe-commits
bcraig added a comment.
ping
https://reviews.llvm.org/D32411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
https://reviews.llvm.org/D32411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
halyavin added a comment.
In https://reviews.llvm.org/D32411#799878, @mclow.lists wrote:
> @smeenai wrote:
>
> > This is kinda ugly, but I can't think of a better way to do it. I'm fine
> > with this, but given that it's a pretty invasive change, I'm not
> > comfortable accepting. You may
mclow.lists added a comment.
@smeenai wrote:
> This is kinda ugly, but I can't think of a better way to do it. I'm fine with
> this, but given that it's a pretty invasive change, I'm not comfortable
> accepting. You may wanna ping @EricWF and @mclow.lists directly.
I'll be meeting with the MS
smeenai resigned from this revision.
smeenai added a comment.
Sorry, I've been meaning to respond for a while.
This is kinda ugly, but I can't think of a better way to do it. I'm fine with
this, but given that it's a pretty invasive change, I'm not comfortable
accepting. You may wanna ping
bcraig added a comment.
ping
https://reviews.llvm.org/D32411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
https://reviews.llvm.org/D32411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated this revision to Diff 100650.
bcraig edited the summary of this revision.
https://reviews.llvm.org/D32411
Files:
CMakeLists.txt
docs/DesignDocs/IncludeNextEmulation.rst
include/__config
include/__config_site.in
include/complex.h
include/cstddef
include/ctype.h
bcraig added a comment.
I'm still working on this.
Things I've learned: A clang install is bundled with re-implementations of
several of these headers. The default #include_next behavior ends up pulling
in lots of those.
I have been able to get things working with a VC include path and a
bcraig added a comment.
In https://reviews.llvm.org/D32411#735128, @halyavin wrote:
> BTW, the list of include files which are located in [PROGRAM_FILES]\Microsoft
> Visual Studio 14.0\VC\include directory is
>
> - stdbool.h
> - limits.h
> - stdint.h
> - setjmp.h
>
> The rest is in
halyavin added a comment.
BTW, the list of include files which are located in [PROGRAM_FILES]\Microsoft
Visual Studio 14.0\VC\include directory is
- stdbool.h
- limits.h
- stdint.h
- setjmp.h
The rest is in [PROGRAM_FILES]\Windows Kits\10\Include\10.0.whatever.0\ucrt
directory. Which
halyavin added a comment.
Here is how we solved this problem in our libc++ fork:
#define _LIBCPP_UCRT_INCLUDE(x) <../ucrt/x>
#define _LIBCPP_MSVC_INCLUDE(x) <../../VC/include/x>
#ifdef _LIBCPP_COMPILER_MSVC
#include _LIBCPP_UCRT_INCLUDE(wchar.h)
#else
#include_next
#endif
As
bcraig created this revision.
Herald added a subscriber: mgorny.
Visual Studio 2015 and 2017 don't implement include_next, so we'll use a
combination of a computed include and a CMAKE input to make it work. Also,
retrofit all the existing invocations of #include_next that we could hit in a
17 matches
Mail list logo
