This revision was automatically updated to reflect the committed changes.
Closed by commit rL305022: [ASTMatchers] Add clang-query support for equals
matcher (authored by Lekensteyn).
Changed prior to commit:
https://reviews.llvm.org/D33094?vs=101817=101967#toc
Repository:
rL LLVM
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D33094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Lekensteyn added inline comments.
Comment at: unittests/ASTMatchers/Dynamic/RegistryTest.cpp:545
+ .getTypedMatcher();
+ EXPECT_TRUE(matches("int x = 'x';", CharStmt));
+ EXPECT_FALSE(matches("int x = 120;", CharStmt));
Lekensteyn wrote:
> aaron.ballman
Lekensteyn updated this revision to Diff 101817.
Lekensteyn marked 7 inline comments as done.
Lekensteyn added a comment.
diff from previous patch:
diff --git a/unittests/ASTMatchers/Dynamic/RegistryTest.cpp
b/unittests/ASTMatchers/Dynamic/RegistryTest.cpp
index 29fcdec6c1..84e31f721a
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3846
+ CXXBoolLiteralExpr,
+ IntegerLiteral),
+
Lekensteyn added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3846
+ CXXBoolLiteralExpr,
+ IntegerLiteral),
+
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3846
+ CXXBoolLiteralExpr,
+ IntegerLiteral),
+
Lekensteyn updated this revision to Diff 98917.
Lekensteyn marked 9 inline comments as done.
Lekensteyn retitled this revision from "[ASTMatchers] Add equals support for
integer and boolean literals" to "[ASTMatchers] Add clang-query support for
equals matcher".
Lekensteyn edited the summary of
