[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

2017-07-27 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added inline comments. Comment at: lib/Basic/Targets/AArch64.cpp:94 llvm::AArch64::parseCPUArch(Name) != - static_cast(llvm::AArch64::ArchKind::AK_INVALID); + llvm::AArch64::ArchKind::INVALID; } rovka wrote: > My eyes might

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

2017-07-27 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 108479. fhahn marked an inline comment as done. fhahn added a comment. Addressed reviewer comments https://reviews.llvm.org/D35884 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.cpp lib/Basic/Targets/ARM.h lib/Driver/ToolChain.cpp

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

2017-07-27 Thread Diana Picus via Phabricator via cfe-commits
rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. Looks entirely mechanical, I don't see any problem with it (just a couple of nits). Comment at: lib/Basic/Targets/AArch64.cpp:94 llvm::AArch64::parseCPUArch(Name)

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

2017-07-26 Thread Florian Hahn via Phabricator via cfe-commits
fhahn created this revision. Herald added subscribers: kristof.beyls, aemerson. This updates the relevant Clang parts for the LLVM change https://reviews.llvm.org/D35882. https://reviews.llvm.org/D35884 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.cpp