This revision was automatically updated to reflect the committed changes.
Closed by commit rL314704: [refactor] Simplify the refactoring interface
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D37681?vs=115211=117403#toc
Repository:
rL LLVM
arphaman added a comment.
I will commit this today. @klimek, let me know if there any issues in
post-commit review.
Repository:
rL LLVM
https://reviews.llvm.org/D37681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
@klimek Have you got a chance to take a look?
Repository:
rL LLVM
https://reviews.llvm.org/D37681
___
cfe-commits mailing list
arphaman updated this revision to Diff 115211.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Make methods private
Repository:
rL LLVM
https://reviews.llvm.org/D37681
Files:
include/clang/Tooling/Refactoring/RefactoringActionRule.h
ioeric added a comment.
This is very nice! Thanks!
Looks good to me; I'll let Manuel stamp the patch for you.
Comment at: include/clang/Tooling/Refactoring/RefactoringActionRules.h:56
+ virtual Expected
+ createSourceReplacements(RefactoringRuleContext ) = 0;
+
arphaman created this revision.
Herald added a subscriber: mgorny.
This patch tries to simplify the interface for the refactoring action rules and
refactoring requirements. It merges the selection constraints and selection
requirements into one class. The refactoring actions rules must now be
