This revision was automatically updated to reflect the committed changes.
Closed by commit rL315048: Refine generation of TBAA information in clang
(authored by kosarev).
Changed prior to commit:
https://reviews.llvm.org/D37826?vs=117823&id=117961#toc
Repository:
rL LLVM
https://reviews.llv
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D37826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
kosarev added inline comments.
Comment at: lib/CodeGen/CodeGenTBAA.h:129
- /// getBaseTypeInfo - Get metadata node for a given base access type.
- llvm::MDNode *getBaseTypeInfo(QualType QType);
+ /// getTBAABaseTypeMetadata - Get metadata that describes the given base
+ ///
kosarev updated this revision to Diff 117823.
kosarev added a comment.
- Rebased on top of https://reviews.llvm.org/D38503.
- The tbaa-for-vptr.cpp test is changed to be more specific about the
instructions to test. Otherwise, we fail on some triples, such as
s390x-ibm-linux and x86_64-pc-mingw3
rjmccall added a comment.
In https://reviews.llvm.org/D37826#888086, @kosarev wrote:
> In https://reviews.llvm.org/D37826#887820, @rjmccall wrote:
>
> > I assume I should wait on reviewing this until all of these smaller TBAA
> > patches land?
>
>
> These small patches are actually part of this
kosarev added a comment.
In https://reviews.llvm.org/D37826#887820, @rjmccall wrote:
> I assume I should wait on reviewing this until all of these smaller TBAA
> patches land?
These small patches are actually part of this diff. Generally, It depends on
how you would like it: if you can review
kosarev updated this revision to Diff 117653.
kosarev added a comment.
Rebased.
This is how how the rebased patch differs from the mainline:
- It incorporates changes from (not landed yet) https://reviews.llvm.org/D38503.
- Simplifies generation of TBAA info in EmitLValueForField().
- Replaces T
rjmccall added a comment.
I assume I should wait on reviewing this until all of these smaller TBAA
patches land?
https://reviews.llvm.org/D37826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Thanks for the ack Daniel. Hopefully others will eventually have a
chance to review.
On 27/09/17 19:00, Daniel Berlin wrote:
(As i mentioned to hal offline, i'm too slammed to help here)
On Wed, Sep 27, 2017 at 8:47 AM, Ivan A. Kosarev via Phabricator
mailto:revi...@reviews.llvm.org>> wrote:
(As i mentioned to hal offline, i'm too slammed to help here)
On Wed, Sep 27, 2017 at 8:47 AM, Ivan A. Kosarev via Phabricator <
revi...@reviews.llvm.org> wrote:
> kosarev added a comment.
>
> Colleagues, please let me know if I can do anything else to help with
> reviewing the patch. Thanks.
>
>
kosarev added a comment.
Colleagues, please let me know if I can do anything else to help with reviewing
the patch. Thanks.
https://reviews.llvm.org/D37826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
11 matches
Mail list logo