[PATCH] D40948: Switch Clang's default C++ language target to C++14

t.p.northover closed this revision. t.p.northover added a comment. Thanks Richard, and all other reviewers. I committed this as r320250, with a couple of sanitizer test fixes as r320251 and r320284 (thanks Ahmed!). Repository: rC Clang https://reviews.llvm.org/D40948

[PATCH] D40948: Switch Clang's default C++ language target to C++14

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with the PS4 comment removed. Thank you! Please also update the documentation and the release notes. Comment at:

[PATCH] D40948: Switch Clang's default C++ language target to C++14

probinson added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1733 // The PS4 uses C++11 as the default C++ standard. - if (T.isPS4()) -LangStd = LangStandard::lang_gnucxx11; - else -LangStd = LangStandard::lang_gnucxx98;

[PATCH] D40948: Switch Clang's default C++ language target to C++14

filcab added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1733 // The PS4 uses C++11 as the default C++ standard. - if (T.isPS4()) -LangStd = LangStandard::lang_gnucxx11; - else -LangStd = LangStandard::lang_gnucxx98; +

[PATCH] D40948: Switch Clang's default C++ language target to C++14

t.p.northover added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1733 // The PS4 uses C++11 as the default C++ standard. - if (T.isPS4()) -LangStd = LangStandard::lang_gnucxx11; - else -LangStd =

[PATCH] D40948: Switch Clang's default C++ language target to C++14

filcab added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1733 // The PS4 uses C++11 as the default C++ standard. - if (T.isPS4()) -LangStd = LangStandard::lang_gnucxx11; - else -LangStd = LangStandard::lang_gnucxx98; +

[PATCH] D40948: Switch Clang's default C++ language target to C++14

t.p.northover added inline comments. Comment at: clang/test/CodeGenCXX/new-overflow.cpp:88 // CHECK: [[N:%.*]] = sext i16 {{%.*}} to i32 - // CHECK-NEXT: [[T0:%.*]] = icmp slt i32 [[N]], 0 - // CHECK-NEXT: [[T1:%.*]] = select i1 [[T0]], i32 -1, i32 [[N]] - //

[PATCH] D40948: Switch Clang's default C++ language target to C++14

t.p.northover updated this revision to Diff 126129. t.p.northover added a comment. Updating with tentative fixes to review comments. Repository: rC Clang https://reviews.llvm.org/D40948 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CodeGenCXX/new-overflow.cpp

[PATCH] D40948: Switch Clang's default C++ language target to C++14

rsmith added a comment. In https://reviews.llvm.org/D40948#948843, @t.p.northover wrote: > Thanks Richard. I'll file the bugs tomorrow for the issues you suggest. Do > you see either of them blocking the change to C++14 as a default? On a scale > of "no", "no but I want a commitment to fix

[PATCH] D40948: Switch Clang's default C++ language target to C++14

t.p.northover added a comment. Thanks Richard. I'll file the bugs tomorrow for the issues you suggest. Do you see either of them blocking the change to C++14 as a default? On a scale of "no", "no but I want a commitment to fix them" and "yes" sort of thing. Tonight I've just got one comment

[PATCH] D40948: Switch Clang's default C++ language target to C++14

rsmith added inline comments. Comment at: clang/test/CodeGenCXX/new-overflow.cpp:88 // CHECK: [[N:%.*]] = sext i16 {{%.*}} to i32 - // CHECK-NEXT: [[T0:%.*]] = icmp slt i32 [[N]], 0 - // CHECK-NEXT: [[T1:%.*]] = select i1 [[T0]], i32 -1, i32 [[N]] - // CHECK-NEXT:

[PATCH] D40948: Switch Clang's default C++ language target to C++14

t.p.northover added inline comments. Comment at: clang/test/SemaCXX/new-array-size-conv.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -pedantic -verify %s +// RUN: %clang_cc1 -fsyntax-only -pedantic -verify -std=gnu++98 %s // RUN: %clang_cc1 -fsyntax-only -pedantic -verify -std=c++98

[PATCH] D40948: Switch Clang's default C++ language target to C++14

probinson added a reviewer: rjmccall. probinson added a comment. +rjmccall for the codegen bits. Comment at: clang/test/SemaCXX/new-array-size-conv.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -pedantic -verify %s +// RUN: %clang_cc1 -fsyntax-only -pedantic -verify -std=gnu++98 %s

Re: [PATCH] D40948: Switch Clang's default C++ language target to C++14

> + LangStd = LangStandard::lang_gnucxx14; > > This comment should be removed. Opps, yep. Fixed on my local branch. I won't upload a new diff just yet though. Thanks. Tim. ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40948: Switch Clang's default C++ language target to C++14

Hahnfeld added a reviewer: ABataev. Hahnfeld added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1732 case InputKind::ObjCXX: // The PS4 uses C++11 as the default C++ standard. + LangStd = LangStandard::lang_gnucxx14;

Re: [PATCH] D40948: Switch Clang's default C++ language target to C++14

Here's the test-suite diff. It's really just a few ancient code-bases that don't compile with C++14, no runtime issues I noticed. Tim. commit a52b065052bfefaac17e7096fd2c911aac62e9da Author: Tim Northover Date: Thu Dec 7 09:16:34 2017 + Support C++14 as a

[PATCH] D40948: Switch Clang's default C++ language target to C++14

t.p.northover created this revision. Herald added a subscriber: mcrosier. Hi all, So, I've finally managed to run all the tests I wanted and get this out for review. Sorry it's taken so long. This patch switches Clang's default C++ target to C++14 across all platforms and updates the