[PATCH] D42942: [clangd] Collect definitions when indexing.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324735: [clangd] Collect definitions when indexing. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D42942?vs=133502=133613#toc Repository: rL LLVM

[PATCH] D42942: [clangd] Collect definitions when indexing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324735: [clangd] Collect definitions when indexing. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clangd/index/SymbolCollector.cpp:210 + BasicSymbol = addDeclaration(*ND, std::move(ID)); +if (Roles & static_cast(index::SymbolRole::Definition)) +

[PATCH] D42942: [clangd] Collect definitions when indexing.

ioeric accepted this revision. ioeric added a comment. Lg Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance ) override { +const auto

[PATCH] D42942: [clangd] Collect definitions when indexing.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clangd/index/Index.h:129 // - // A C++ symbol could have multiple declarations and one definition (e.g. - // a function is declared in ".h" file, and

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall updated this revision to Diff 133502. sammccall added a comment. Revert hack in global-symbol-builder to filter the input files. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42942 Files: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall added a comment. Thanks for the comments! And sorry for the delay, I was haunted by useless gtest messages, which https://reviews.llvm.org/D43091 should fix. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:159 + // Output phase: emit YAML for

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall updated this revision to Diff 133501. sammccall marked 6 inline comments as done. sammccall added a comment. Address review comments. Make SymbolsToYAML take an ostream instead of returning a string. Define SymbolSlab::iterator so googletest will print it as a container. Repository:

[PATCH] D42942: [clangd] Collect definitions when indexing.

hokein added inline comments. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance ) override { +const auto =

[PATCH] D42942: [clangd] Collect definitions when indexing.

ioeric added inline comments. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance ) override { +const auto =

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall added a comment. OK, I think this is good to go now. Rebased against Eric's URI change and added tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall updated this revision to Diff 133024. sammccall added a comment. Add tests for SymbolCollector (finding def/decl locations) and merge. Found some bugs in SymbolCollector's locations - added fixmes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42942 Files:

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall added a comment. Thanks for comments! (Still not done, adding tests) Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance ) override {

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall updated this revision to Diff 132985. sammccall marked 3 inline comments as done. sammccall added a comment. [clangd] Prefer data from TUs with symbol defn to data from TUs without. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42942 Files:

[PATCH] D42942: [clangd] Collect definitions when indexing.

hokein added a comment. I like where the patch is going now. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance ) override { +const

[PATCH] D42942: [clangd] Collect definitions when indexing.

ioeric added a comment. looks good Comment at: clangd/index/Index.h:25 struct SymbolLocation { // The absolute path of the source file where a symbol occurs. It might be worth mentioning here whether the range covers the entire declaration/definition

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall added a comment. This does seem to get at least the simple cases right: ID: 0EF8AF4D08B11EBF3FFB8004CE702991B15F Name:SymbolsFromYAML Scope: 'clang::clangd::' SymInfo: Kind:Function Lang:C

[PATCH] D42942: [clangd] Collect definitions when indexing.

sammccall created this revision. sammccall added reviewers: ioeric, hokein. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek. (This isn't done! Needs new tests, and some random cleanups should be split out. Looking for some early feedback.) Within a TU: - as now,