[PATCH] D43171: [AMDGPU] Change constant addr space to 4 for clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC325031: [AMDGPU] Change constant addr space to 4 (authored by yaxunl, committed by ). Changed prior to commit: https://reviews.llvm.org/D43171?vs=133802&id=134071#toc Repository: rC Clang https://re

[PATCH] D43171: [AMDGPU] Change constant addr space to 4 for clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL325031: [AMDGPU] Change constant addr space to 4 (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43171?vs=133802&id=13407

[PATCH] D43171: [AMDGPU] Change constant addr space to 4 for clang

yaxunl added inline comments. Comment at: test/CodeGenOpenCL/address-spaces.cl:37 +// SPIR: i32 addrspace(2)* %arg +// GIZ: i32 addrspace(4)* %arg void f__c(__constant int *arg) {} t-tye wrote: > Suggest using the same name across all the OpenCL tests as some ar

[PATCH] D43171: [AMDGPU] Change constant addr space to 4 for clang

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM. Other clean up can be done as a separate patch. Comment at: test/CodeGenOpenCL/address-spaces.cl:37 +// SPIR: i32 addrspace(2)* %arg +// GIZ: i32 addrspace(4)* %arg void

[PATCH] D43171: [AMDGPU] Change constant addr space to 4 for clang

yaxunl created this revision. yaxunl added reviewers: t-tye, b-sumner, arsenm. Herald added subscribers: tpr, dstuttard, nhaehnle, wdng, kzhuravl. https://reviews.llvm.org/D43171 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/Basic/Targets/AMDGPU.cpp test/CodeGen/target-data.c test/Cod