Eric,
Any chance you could have one more look at this and let me know if the
patch is acceptable?
Thanks,
Mike
On Mon, Mar 5, 2018 at 4:16 PM, Mike Edwards via Phabricator <
revi...@reviews.llvm.org> wrote:
> sqlbyme updated this revision to Diff 137104.
> sqlbyme added a comment.
>
> I copied
sqlbyme updated this revision to Diff 137104.
sqlbyme added a comment.
I copied what Eric did here:
https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e.
I have tested this on our bots and the fix works fine.
https://reviews.llvm.org/D44103
Files:
EricWF added a comment.
I think the correct fix is something like this:
https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e
Repository:
rCXX libc++
https://reviews.llvm.org/D44103
___
cfe-commits mailing list
vsapsai added a comment.
In https://reviews.llvm.org/D44103#1027664, @vsk wrote:
> Is the test expected to pass with clang-902? If not, then it'd be best to use
> "apple-clang-9" instead of "apple-clang-9.0".
That means that most likely it should be `apple-clang-8` instead of 8.0. But on
the
vsk added a comment.
Is the test expected to pass with clang-902? If not, then it'd be best to use
"apple-clang-9" instead of "apple-clang-9.0".
Repository:
rCXX libc++
https://reviews.llvm.org/D44103
___
cfe-commits mailing list
sqlbyme created this revision.
sqlbyme added reviewers: EricWF, dexonsmith.
Herald added a subscriber: cfe-commits.
I am in the process of upgrading the Green Dragon bots and this test fails
because we have not yet included apple-clang-9.0 in the UNSUPPORTED line of
this test. This patch
