[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth abandoned this revision. JonasToth added a comment. Herald added a subscriber: whisperity. Abonding this revision in favor of: https://reviews.llvm.org/D54943 It doesn't make sense to have both open at the same time, as the const-transformation happens in its own patch and no heavy

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. > Are you going to keep updating it on > https://github.com/JonasToth/llvm-project/commits/feature_check_const ? Yup, thats my backup if something goes wrong and to synchronize my pcs. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

0x8000- added a comment. In D45444#1766852 , @JonasToth wrote: > > Thank you for testing, I would appreciate if you test later versions, too! > I will focus on landing the utility function for adding `const` first. I > noticed false positives in

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. In D45444#1766156 , @0x8000- wrote: > Thank you for rebasing on current master. > > I have ran it today on our code base and found three classes of false > positives: > > 1. Writing to a bitfield of a struct. The struct

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

0x8000- added a comment. Thank you for rebasing on current master. I have ran it today on our code base and found three classes of false positives: 1. Writing to a bitfield of a struct. The struct still is suggested it should be const. 2. Using a variable with an ostream extraction; like

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 229818. JonasToth added a comment. - update license - rebase to master and patch for adding const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45444/new/ https://reviews.llvm.org/D45444 Files:

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Herald added a subscriber: mgehre. In D45444#1685995 , @tsdgeos wrote: > Would this warn with stuff like > > double borderWidth; > [... code that doesn't use borderWidth ...] > borderWidth = border->getWidth(); > [...

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

tsdgeos added a comment. Herald added a subscriber: wuzish. Herald added a project: clang. Would this warn with stuff like double borderWidth; [... code that doesn't use borderWidth ...] borderWidth = border->getWidth(); [... code that reads borderWidth ...] Repository: rCTE Clang

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 182356. JonasToth added a comment. - avoid bitrot Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45444/new/ https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 175445. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45444/new/ https://reviews.llvm.org/D45444 Files:

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 174942. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 173653. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. I am, but this revision relies on support on the analysis in the frontend. This seems currently stalled as the developer there seems busy with other stuff. Once i implement transofmration-capabilites i will evaluate if there are any false-positives that would break.

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

xbolva00 added a comment. Are you still looking at this? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 165568. JonasToth added a comment. - fix actually use clang-analyses correctly Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Soonish it might be able to do so ;) Am 14.09.2018 um 17:13 schrieb Dávid Bolvanský via Phabricator: > xbolva00 added a comment. > > Yeah, it would be super useful if Clang can add const to all places where > possible :) love this work, great! > > Repository: > >

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

xbolva00 added a comment. Yeah, it would be super useful if Clang can add const to all places where possible :) love this work, great! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 165497. JonasToth added a comment. - update to ExprMutAnalyzer living in clang now Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. F7179032: llvm_lib_references.out F7179031: llvm_lib_pointer_values.out F7179030: llvm_lib_values.out Here are results for `llvm/lib` with the current version.

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 164898. JonasToth added a comment. - ignore lambdas properly Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 162449. JonasToth added a comment. - get up to date Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Thank you very much :) Am 12.08.2018 um 00:17 schrieb Shuai Wang via Phabricator: > shuaiwang added a comment. > > In https://reviews.llvm.org/D45444#1196271, @JonasToth wrote: > >> Always the same with the templates ;) So uninstantiated templates should >> >>

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

shuaiwang added a comment. In https://reviews.llvm.org/D45444#1196271, @JonasToth wrote: > Always the same with the templates ;) So uninstantiated templates should > just be ignored. > > I think it would be better to have it in the ExprMutAnalyzer, because > that part can not decide on

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 160239. JonasToth added a comment. - explicitly ignore lambdas in VarDecls Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Always the same with the templates ;) So uninstantiated templates should just be ignored. I think it would be better to have it in the ExprMutAnalyzer, because that part can not decide on const-ness. Fixing it here would just circumvent the problem but not fix it,

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

shuaiwang added a comment. In https://reviews.llvm.org/D45444#1191874, @JonasToth wrote: > > Could you give a concrete example of this? > > vi llvm/lib/Demangle/ItaniumDemangle.cpp +1762 > > /home/jonas/opt/llvm/lib/Demangle/ItaniumDemangle.cpp:1762:7: warning: > variable 'num' of type 'char

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159775. JonasToth added a comment. - fix bug with AnalyzeValues==false skipping whole check, adjust test code to 'const' instead of const Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files:

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. > Could you give a concrete example of this? vi llvm/lib/Demangle/ItaniumDemangle.cpp +1762 /home/jonas/opt/llvm/lib/Demangle/ItaniumDemangle.cpp:1762:7: warning: variable 'num' of type 'char [FloatData::max_demangled_size]' can be declared 'const'

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

shuaiwang added a comment. > - there seems to be a false positive with array-to-pointer decay. > ExprMutAnalyzer does think of it, but maybe there is a bug in it. Could you give a concrete example of this? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. For reference, here is the output for llvm/lib. F6896569: const_correctness_2_llvm_lib_references F6896567: const_correctness_2_llvm_lib_values_pointers Things i noticed: - lambdas are warned

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. In https://reviews.llvm.org/D45444#1189262, @aaron.ballman wrote: > However, I'm wondering how this should integrate with other const-correctness > efforts like `readability-non-const-parameter`? I think this check/functionality will kinda replace the

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159390. JonasToth marked 4 inline comments as done. JonasToth added a comment. - address review issues, todos/fixmes and diag nit Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:183 + // TODO Implement automatic code transformation to add the 'const'. + diag(Variable->getLocStart(), "variable %0 of type %1 can

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:147 + // Example: `int i = 10`, `int i` (will be used if program is correct) + const auto LocalValDecl = varDecl(unless(anyOf( +

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

aaron.ballman added a comment. The functionality is looking good, aside from a few small nits remaining. However, I'm wondering how this should integrate with other const-correctness efforts like `readability-non-const-parameter`? Also, I'm wondering how this check performs over a large code

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159226. JonasToth added a comment. - update ReleaseNotes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159225. JonasToth marked an inline comment as done. JonasToth added a comment. - fix typo Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:147 + // Example: `int i = 10`, `int i` (will be used if program is correct) + const auto LocalValDecl = varDecl(unless(anyOf( + isLocal(), hasInitializer(anything()),

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159224. JonasToth added a comment. - revert breaking change in LocalVar matcher. Reverting the change from `allOf(...)` to `unless(anyOf(..))`. I did not investigate the reason for it breaking, because basic logic suggests that transformation should be

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159221. JonasToth added a comment. - doc list Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:141-142 +void ConstCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) +return; + aaron.ballman wrote: > Why is this check disabled for C

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159220. JonasToth marked 11 inline comments as done. JonasToth added a comment. - Merge branch 'master' into check_const - [Misc] rename and first review comments - language stuff Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

xbolva00 added inline comments. Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:28 + * For now: Only local variables are considered. Globals/namespace variables, + * paramters and class members are not analyzed. + * Parameters have a check already:

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. > I'm sorry for the delay in reviewing this; I'm not certain how it fell off my > radar for so long! No problem :) Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:32 + * + * Handle = either a pointer or reference + * Value = everything

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

aaron.ballman added a comment. I'm sorry for the delay in reviewing this; I'm not certain how it fell off my radar for so long! Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:32 + * + * Handle = either a pointer or reference + * Value = everything else (Type

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159062. JonasToth added a comment. get check up to 8.0 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCheck.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 158285. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCheck.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. @aaron.ballman Are you missing something in this check/tests? I think i will remove the big comment with my thoughts on what has to be done, or do you think it would help for reference? I would probably be able to finalize this week if there is no major issue, so it

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Yes, but that is complicated. Functionality for that will first be implemented in the libTooling and then utilized here later. Am 19.07.2018 um 04:16 schrieb Florin Iucha via Phabricator: > 0x8000- added a comment. > > Any plans for fix-its that will add the

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

0x8000- added a comment. Any plans for fix-its that will add the suggested 'const' qualifiers? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

Eugene.Zelenko added a comment. > But you could also take a look at the enforcement of some coding > guidelines (my personal todolists: > https://github.com/JonasToth/CppCoreGuidelinesTooling  > https://github.com/JonasToth/HighIntegrityTooling). There are always low > hanging fruit checks.

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. What do you mean by "The code is a bit more intimidating", the check itself or the amount of tests? In general the utility piece that was commited before this check should already analyze the constness good, given that this check builds upon it the functionality should

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

0x8000- added a comment. In https://reviews.llvm.org/D45444#1164671, @JonasToth wrote: > @0x8000- are you interested in working on the check? If i recall > correctly the branch for 7.0 will happen on 1. august. That would be the > timewindow in which it makes sense to give you the

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 155821. JonasToth added a comment. - Merge branch 'master' into check_const - [Misc] remove comment and iostream Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth marked an inline comment as done. JonasToth added a comment. Removed one unresolved comment, probably thats why it was stuck :D Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. @0x8000- are you interested in working on the check? If i recall correctly the branch for 7.0 will happen on 1. august. That would be the timewindow in which it makes sense to give you the patch. I will have time in september following, but not right now. I try

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Yes. https://github.com/JonasToth/clang-tools-extra/tree/check_const This is the branch i work on. I got it up to date with the current master for CTE. :) Am 14.07.2018 um 20:59 schrieb Florin Iucha via Phabricator: > 0x8000- added a comment. > > In

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

0x8000- added a comment. In https://reviews.llvm.org/D45444#1162715, @JonasToth wrote: > Time :/ Is this available as a public Git branch somewhere, or is downloading the diff the preferred way to interact with this code? Repository: rCTE Clang Tools Extra

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. Time :/ Am 14.07.2018 um 16:34 schrieb Roman Lebedev via Phabricator: > lebedev.ri added a comment. > > Ping, i guess :) > Anything needed to get this going? > > Repository: > > rCTE Clang Tools Extra > > https://reviews.llvm.org/D45444 Repository: rCTE

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

lebedev.ri added a comment. Ping, i guess :) Anything needed to get this going? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 153282. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCheck.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. - fixed some comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 153268. JonasToth marked 4 inline comments as done. JonasToth added a comment. - [Misc] order in release notes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt