[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

2018-04-24 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal closed this revision. BillyONeal added a comment. D:\msvc\src\qa\VC\Libs\libcxx\upstream>git svn dcommit Committing to https://llvm.org/svn/llvm-project/libcxx/trunk ... Authentication realm: https://llvm.org:443 LLVM Subversion repository Password for 'bion': M

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

2018-04-23 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal added a comment. In https://reviews.llvm.org/D45715#1075665, @mclow.lists wrote: > - if there are similar tests in the filesystem test suite, and you haven't > tripped over them because you spelled your error message the same as we did. Almost certainly. But we aren't running your

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

2018-04-23 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. I'm fine with this change, but I'm wondering: - if there are similar tests in the filesystem test suite, and you haven't tripped over them because you spelled your error message the same as we did. - Should part of this test be moved into test/libcxx

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

2018-04-16 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal updated this revision to Diff 142733. BillyONeal added a comment. Added missing include in one of the tests. https://reviews.llvm.org/D45715 Files: test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/ctor_char_pointer_error_code.pass.cpp

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

2018-04-16 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. Remove nonportable assumption in io_error tests that std::errc::is_a_directory has message "Is a directory". On MSVC++ it reports "is a directory" (with a lowercase I). https://reviews.llvm.org/D45715 Files: