[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

This revision was automatically updated to reflect the committed changes. Closed by commit rL339571: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after… (authored by mboehme, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

mboehme added a comment. Thank you for the review! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

mboehme updated this revision to Diff 160347. mboehme added a comment. Rebase to head. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49910 Files: clang-tidy/bugprone/UseAfterMoveCheck.cpp docs/clang-tidy/checks/bugprone-use-after-move.rst

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! An attribute really is the right way to go for this sort of thing, and it sounds like you've got a base of users looking for the functionality. Repository: rCTE Clang

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

mboehme added a comment. Sorry, that code got formatted strangely. Here's the same code block in more legible form: MyContainer container; T t; while (GetNextT()) { container.Add(t); if (SomeCondition()) { PassToConsumer(std::move(container)); container.Clear(); }

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

mboehme added a comment. In https://reviews.llvm.org/D49910#1187809, @aaron.ballman wrote: > In https://reviews.llvm.org/D49910#1187492, @mboehme wrote: > > > In https://reviews.llvm.org/D49910#1187455, @aaron.ballman wrote: > > > > > Are you going to propose adding this attribute to libc++, or

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

aaron.ballman added a comment. In https://reviews.llvm.org/D49910#1187492, @mboehme wrote: > In https://reviews.llvm.org/D49910#1187455, @aaron.ballman wrote: > > > Are you going to propose adding this attribute to libc++, or is this > > expected to only work with UDTs? > > > I don't have any

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

mboehme added a comment. In https://reviews.llvm.org/D49910#1187455, @aaron.ballman wrote: > Are you going to propose adding this attribute to libc++, or is this expected > to only work with UDTs? I don't have any experience contributing to libc++, but I think this would make sense. The

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Are you going to propose adding this attribute to libc++, or is this expected to only work with UDTs? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49910 ___

[PATCH] D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move

mboehme added a comment. Any comments? https://reviews.llvm.org/D49911, on which this relies, is now ready to land. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org