This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE339547: [clangd] Introduce scoring mechanism for
SignatureInformations. (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50555?vs=160306=160307#toc
kadircet updated this revision to Diff 160306.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Rebase & Resolve discussions.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50555
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM with a few NITs
Comment at: clangd/CodeComplete.cpp:687
+struct ScoredSignatureGreater {
+ bool operator()(const ScoredSignature , const
kadircet updated this revision to Diff 160097.
kadircet marked 3 inline comments as done.
kadircet added a comment.
Herald added a subscriber: mgrang.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50555
Files:
clangd/CodeComplete.cpp
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:715
unsigned NumCandidates) override {
+TopN Top(
+std::numeric_limits::max());
Maybe use `vector`, followed by `std::sort` at the end?
Or is
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50555
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
