[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

rsmith abandoned this revision. rsmith added a comment. Herald added a subscriber: dang. The constituent pieces have all landed. https://reviews.llvm.org/D51240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

dexonsmith added a comment. In https://reviews.llvm.org/D51240#1213358, @davidxl wrote: > Re "Why not": > > The common use model of instrumentation based PGO and SamplePGO are quite > different. The former usually uses 'fresh' profile that matches the source. > If there are massive code

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

davidxl added a comment. Re "Why not": The common use model of instrumentation based PGO and SamplePGO are quite different. The former usually uses 'fresh' profile that matches the source. If there are massive code refactoring or ABI changes, the user can simply regenerate the profile. For

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

rsmith added a comment. In https://reviews.llvm.org/D51240#1213179, @davidxl wrote: > Can you split the patch into two? One for sample PGO and one for > instrumentation. I've split the patch up thusly: https://reviews.llvm.org/D51246 is the common infrastructure shared by sample PGO and

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

dexonsmith added a reviewer: vsk. dexonsmith added a comment. In https://reviews.llvm.org/D51240#1213179, @davidxl wrote: > In particular, I don't see much need to do this for instrumentation based PGO > [...] Why not? https://reviews.llvm.org/D51240

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

davidxl added a comment. thanks for working on this. Can you split the patch into two? One for sample PGO and one for instrumentation. In particular, I don't see much need to do this for instrumentation based PGO, but we can defer discussion on that once the patch is split.

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

rsmith updated this revision to Diff 162505. rsmith added a comment. Herald added a subscriber: hiraditya. (Tweak diff so phabricator shows clang/ and llvm/ prefixes on filenames and add more context.) https://reviews.llvm.org/D51240 Files: clang/docs/ReleaseNotes.rst

[PATCH] D51240: Add a flag to remap manglings when reading profile data information.

rsmith created this revision. rsmith added reviewers: davidxl, tejohnson, dlj, erik.pilkington. Herald added subscribers: dexonsmith, steven_wu, mgorny, mehdi_amini. This can be used to preserve profiling information across codebase changes that have widespread impact on mangled names, but