This revision was automatically updated to reflect the committed changes.
Closed by commit rL363055: [RISCV] Add inline asm constraints I, J K for
RISC-V (authored by lewis-revill, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54091?vs=203367=204043#toc
Repository:
rL
asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: Jim.
This looks good to me, but is blocked on the dependent patch being updated. I
added a minor comment on riscv-inline-asm.c
Comment at:
lewis-revill updated this revision to Diff 203367.
lewis-revill edited the summary of this revision.
lewis-revill added a comment.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
- Rebased and fixed test run line
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
lewis-revill updated this revision to Diff 174360.
lewis-revill edited the summary of this revision.
lewis-revill added a comment.
Updated to reflect desired changes (and fix an incorrect boundary). I didn't
add r & m to riscv-inline-asm.c as I wasn't clear what exactly was desired.
asb requested changes to this revision.
asb added a comment.
This revision now requires changes to proceed.
Thanks for the patch Lewis. Could I please request the following changes:
- It would be handy to link to
https://gcc.gnu.org/onlinedocs/gccint/Machine-Constraints.html in the patch
lewis-revill created this revision.
lewis-revill added a reviewer: asb.
Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o,
brucehoult, MartinMosbeck, rogfer01, mgrang, edward-jones, zzheng, jrtc27,
shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar,
