[PATCH] D54986: Make CodeGen choose when to emit vtables.

v.g.vassilev resigned from this revision. v.g.vassilev added a comment. Herald added a project: All. I think this landed in a different form. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54986/new/ https://reviews.llvm.org/D54986

[PATCH] D54986: Make CodeGen choose when to emit vtables.

v.g.vassilev added a comment. @rsmith, what was the fate of this patch? I thought it landed but cannot find a trace of it in the master... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54986/new/ https://reviews.llvm.org/D54986

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rjmccall added inline comments. Comment at: lib/AST/RecordLayoutBuilder.cpp:3069 const Decl *Result = Entry ? Entry.get(getExternalSource()) : computeKeyFunction(*this, RD); rsmith wrote: > rjmccall wrote: > > Why not just change `computeKeyFunction`

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rsmith marked an inline comment as done. rsmith added a comment. In D54986#1312435 , @lebedev.ri wrote: > Will `-fforce-emit-vtables` still work? Yes, it still works. (The tests for it still pass and I've manually tested it too.)

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rjmccall added inline comments. Comment at: lib/AST/ASTContext.cpp:9801 + RD->getTemplateSpecializationKind() == + TSK_ExplicitInstantiationDefinition; else Does it matter if it's not this particular declaration that's the explicit

[PATCH] D54986: Make CodeGen choose when to emit vtables.

lebedev.ri added a comment. Will `-fforce-emit-vtables` still work? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54986/new/ https://reviews.llvm.org/D54986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rsmith updated this revision to Diff 175791. rsmith added a comment. - Do not emit unused discardable vtables. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54986/new/ https://reviews.llvm.org/D54986 Files: lib/AST/ASTContext.cpp

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3991-3992 + if (auto *MD = dyn_cast(D)) { +// FIXME: There's no reason to do this if the key function is inline. +// Formally, the ABI requires it, but the difference is not observable. +if

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rsmith marked 2 inline comments as done. rsmith added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3991-3992 + if (auto *MD = dyn_cast(D)) { +// FIXME: There's no reason to do this if the key function is inline. +// Formally, the ABI requires it, but the

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3991-3992 + if (auto *MD = dyn_cast(D)) { +// FIXME: There's no reason to do this if the key function is inline. +// Formally, the ABI requires it, but the difference is not observable. +if

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3991-3992 + if (auto *MD = dyn_cast(D)) { +// FIXME: There's no reason to do this if the key function is inline. +// Formally, the ABI requires it, but the

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3991-3992 + if (auto *MD = dyn_cast(D)) { +// FIXME: There's no reason to do this if the key function is inline. +// Formally, the ABI requires it, but the difference is not observable. +if

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3991-3992 + if (auto *MD = dyn_cast(D)) { +// FIXME: There's no reason to do this if the key function is inline. +// Formally, the ABI requires it, but the

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rsmith created this revision. rsmith added reviewers: rjmccall, v.g.vassilev, bruno. Herald added subscribers: cfe-commits, javed.absar. Previously, we expected Sema to make this ABI decision for us, resulting in our emitting vtables in some cases where we didn't need them. With this change, we