This revision was automatically updated to reflect the committed changes.
Closed by commit rC349682: [analyzer] CStringChecker: Fix a crash on C++
overloads of standard functions. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55873?vs=178959&id=17896
NoQ updated this revision to Diff 178959.
NoQ added a comment.
Fxd.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55873/new/
https://reviews.llvm.org/D55873
Files:
lib/StaticAnalyzer/Checkers/CStringChecker.cpp
test/Analysis/string.cpp
Index: test/Analysis/string.cpp
=
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2317-2320
else if (isCPPStdLibraryFunction(FDecl, "copy"))
evalFunction = &CStringChecker::evalStdCopy;
else if (isCPPStdLibraryFunction(FDecl, "copy_backward"))
evalFunction =
NoQ updated this revision to Diff 178938.
NoQ marked an inline comment as done.
NoQ added a comment.
Indeed :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55873/new/
https://reviews.llvm.org/D55873
Files:
lib/StaticAnalyzer/Checkers/CStringChecker.cpp
test/Analysis/string.cpp
I
Szelethus accepted this revision.
Szelethus added a comment.
Cheers!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55873/new/
https://reviews.llvm.org/D55873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/Analysis/string.cpp:23
+
+// A similarly weird override outside of the class.
+void *memcpy(void *, const S &, size_t);
I'm pret
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov,
rnkovacs, Szelethus, mikhail.ramalho, baloghadamsoftware.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet.
It turns out that it's not all that uncommon to have a C++ ove
