[PATCH] D58033: Add option for emitting dbg info for call site parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rL364399: [CC1Option] Add the option to enable the debug entry values (authored by djtodoro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:755 + (Arch == llvm::Triple::x86 || Arch == llvm::Triple::x86_64)) +Opts.EnableDebugEntryValues = Args.hasArg(OPT_femit_debug_entry_values); +

[PATCH] D58033: Add option for emitting dbg info for call site parameters

probinson added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:755 + (Arch == llvm::Triple::x86 || Arch == llvm::Triple::x86_64)) +Opts.EnableDebugEntryValues = Args.hasArg(OPT_femit_debug_entry_values); + You want to disable

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 203335. djtodoro added a comment. -Explicitly enable the option only in the case of X86 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 201503. djtodoro added a comment. -Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/CC1Options.td lib/CodeGen/BackendUtil.cpp

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 200943. djtodoro added a comment. -Add a negative test for -O0 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/CC1Options.td

[PATCH] D58033: Add option for emitting dbg info for call site parameters

aprantl accepted this revision. aprantl added a comment. LGTM, with an additional testcase. Comment at: test/CodeGenCXX/dbg-info-all-calls-described.cpp:23 +// RUN: | FileCheck %s -check-prefix=HAS-ATTR \ +// RUN: -implicit-check-not=DIFlagAllCallsDescribed +

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 200485. djtodoro added a comment. -Set `EnableDebugEntryValues` only for a higher level of optimizations (-O1 and higher) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files:

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 199213. djtodoro edited the summary of this revision. djtodoro added a comment. -Add an input in test/CodeGenCXX/dbg-info-all-calls-described.cpp -Rename the option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro added a comment. @probinson @aprantl Thanks! @vsk Thanks for the comment! Sure, we will add that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 ___ cfe-commits mailing list

[PATCH] D58033: Add option for emitting dbg info for call site parameters

vsk added a comment. I think a small extension to `test/CodeGenCXX/dbg-info-all-calls-described.cpp` for the 'Supported: DWARF4 + -femit_param_entry_values' case would be appropriate here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033

[PATCH] D58033: Add option for emitting dbg info for call site parameters

probinson added a comment. I'm okay with this, but give @aprantl a chance to confirm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 196595. djtodoro marked an inline comment as done. djtodoro edited the summary of this revision. djtodoro added a comment. -Remove unneeded code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files:

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro marked 2 inline comments as done. djtodoro added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3402 +CmdArgs.push_back("-femit-param-entry-values"); + RenderDebugInfoCompressionArgs(Args, CmdArgs, D, TC); probinson wrote: > If this

[PATCH] D58033: Add option for emitting dbg info for call site parameters

probinson added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3402 +CmdArgs.push_back("-femit-param-entry-values"); + RenderDebugInfoCompressionArgs(Args, CmdArgs, D, TC); If this is now a cc1-only option, this part goes away right?

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro added a comment. > Is there some kind of testcase? @aprantl Usage of the option is tested within following patches from the stack. I am not sure if we need some additional test here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033

[PATCH] D58033: Add option for emitting dbg info for call site parameters

aprantl added a comment. Is there some kind of testcase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 196053. djtodoro added a comment. -Add only cc1 option -Set up back end CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/CC1Options.td

[PATCH] D58033: Add option for emitting dbg info for call site parameters

probinson added a comment. In D58033#1470260 , @djtodoro wrote: > @probinson @aprantl Thanks a lot for your comments! > > Let's clarify some things. I'm sorry about the confusion. > > Initial patch for the functionality can be restricted by this option

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 195571. djtodoro added a comment. -Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/Options.td

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 195568. djtodoro retitled this revision from "Add option for emitting dbg info for call sites" to "Add option for emitting dbg info for call site parameters". djtodoro added a comment. -Refactor -Remove `CC1` def CHANGES SINCE LAST ACTION