[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

This revision was automatically updated to reflect the committed changes. Closed by commit rL354057: Stop enabling clang-tools-extra automatically when clang is in… (authored by nico, committed by ). Herald added a project: LLVM. Changed prior to commit:

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

thakis added a comment. Thanks for starting the thread, Reid. In D58157#1397260 , @mehdi_amini wrote: > Sorry, I don't have time to do archeology for you right now. But this is > beside the point: your patch is changing a 2 years status quo, so my take

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

mehdi_amini added a comment. In D58157#1397302 , @rnk wrote: > In D58157#1397274 , @mehdi_amini > wrote: > > > It'd still be nice to identify the end goal with most cfe people (i.e. even > > if you land this

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

phosek added a comment. We need to update https://github.com/llvm/llvm-zorg/blob/master/zorg/buildbot/builders/FuchsiaBuilder.py#L102 as well as our downstream bots, but other than that I'm fine with this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58157/new/

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

rnk added a comment. In D58157#1397274 , @mehdi_amini wrote: > It'd still be nice to identify the end goal with most cfe people (i.e. even > if you land this right now, discussing the desired layout in the monorepo) I sent off

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

mehdi_amini added a comment. In D58157#1396824 , @rnk wrote: > And, this change really just keeps us at parity with what we had with svn. > We can always revisit the decision to merge the clang tools into clang. This > particular change just gives us

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

mehdi_amini added a comment. In D58157#1396072 , @thakis wrote: > In D58157#1395762 , @mehdi_amini > wrote: > > > In D58157#1395716 , @rnk wrote: > > > > > I think we have

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

rnk added a comment. In D58157#1395762 , @mehdi_amini wrote: > In D58157#1395716 , @rnk wrote: > > > I think we have consensus, > > > Based on three comments in a revision? Seems strange to me. > I don't really

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

thakis added a comment. In D58157#1395762 , @mehdi_amini wrote: > In D58157#1395716 , @rnk wrote: > > > I think we have consensus, > > > Based on three comments in a revision? Seems strange to me. > I don't really

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

lebedev.ri added subscribers: cfe-commits, lebedev.ri. lebedev.ri added a comment. cfe-commits (if cfe-dev proper) should probably also be part of this disscussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58157/new/ https://reviews.llvm.org/D58157