[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

morehouse added a comment. This patch caused the Windows sanitizer bot to break: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/44238 Please take a look. FAILED: projects/compiler-rt/lib/fuzzer/tests/FuzzerTestObjects.gtest-all.cc.x86_64.o cmd.exe /C "cd /D

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

This revision was automatically updated to reflect the committed changes. Closed by commit rL357928: [MS] Add metadata for __declspec(allocator) (authored by akhuang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang updated this revision to Diff 194164. akhuang marked 2 inline comments as done. akhuang added a comment. Fixes to test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60237/new/ https://reviews.llvm.org/D60237 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, with some suggestions to improve the test Comment at: clang/test/CodeGen/debug-info-codeview-heapallocsite.c:16-19 +struct Foo foo_buf[1024]; +__declspec(allocator) struct

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang updated this revision to Diff 193792. akhuang marked 3 inline comments as done. akhuang added a comment. -added struct case to test -style fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60237/new/ https://reviews.llvm.org/D60237 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

rnk added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4382-4383 + // Add metadata for calls to MSAllocator functions + if (!DisableDebugInfo) { +if (TargetDecl && TargetDecl->hasAttr()) + getDebugInfo()->addHeapAllocSiteMetadata(CI, RetTy, Loc);

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang updated this revision to Diff 193751. akhuang marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60237/new/ https://reviews.llvm.org/D60237 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1691 } else { -// Build new lvalue for temp address +// Build new lvalue for temp address. Address Ptr = Atomics.materializeRValue(OldRVal);

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

rnk added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1691 } else { -// Build new lvalue for temp address +// Build new lvalue for temp address. Address Ptr = Atomics.materializeRValue(OldRVal); I don't have an issue with these

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang created this revision. akhuang added a reviewer: rnk. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Emit !heapallocsite in the metadata for calls to functions marked with __declspec(allocator). Eventually this will be emitted as S_HEAPALLOCSITE debug info in