This revision was automatically updated to reflect the committed changes.
Closed by commit rL358276: [Aarch64] Add v8.2-a half precision element extract
intrinsics (authored by dnsampaio, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60272/new/
https://reviews.llvm.org/D60272
___
dnsampaio updated this revision to Diff 194826.
dnsampaio marked 2 inline comments as done.
dnsampaio added a comment.
- Used clang-format-diff
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60272/new/
https://reviews.llvm.org/D60272
Files:
LukeGeeson added a comment.
couple of nits, besides from that LGTM
Comment at: lib/CodeGen/CGBuiltin.cpp:7813
}
+ case NEON::BI__builtin_neon_vduph_lane_f16:{
+return Builder.CreateExtractElement(Ops[0], EmitScalarExpr(E->getArg(1)),
nit: spacing
dnsampaio added a comment.
Ping
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60272/new/
https://reviews.llvm.org/D60272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
dnsampaio created this revision.
dnsampaio added reviewers: pablooliveira, olista01, LukeGeeson.
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar.
Herald added a project: clang.
Implements the intrinsics define on the ACLE to extract half precision fp
scalar elements from
