This revision was automatically updated to reflect the committed changes.
Closed by commit rC359344: [HIP] Fix visibility of `__constant__` variables.
(authored by hliao, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61194?vs=196857=196902#toc
Repository:
rC Clang
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61194/new/
https://reviews.llvm.org/D61194
hliao marked an inline comment as done.
hliao added inline comments.
Comment at: clang/test/CodeGenCUDA/amdgpu-visibility.cu:1
+// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device
-fapply-global-visibility-to-externs -fvisibility default -emit-llvm -o - %s |
hliao marked an inline comment as done.
hliao added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:7851
+ (isa(D) &&
+ (D->hasAttr() || D->hasAttr()));
}
yaxunl wrote:
> is format right?
yeah, it's the format after clang-format.
yaxunl added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:7851
+ (isa(D) &&
+ (D->hasAttr() || D->hasAttr()));
}
is format right?
Comment at: clang/test/CodeGenCUDA/amdgpu-visibility.cu:1
+// RUN: %clang_cc1
hliao created this revision.
hliao added a reviewer: yaxunl.
Herald added subscribers: cfe-commits, nhaehnle, jvesely.
Herald added a project: clang.
- `__constant__` variables should not be `hidden` as the linker may turn them
into `LOCAL` symbols.
Repository:
rG LLVM Github Monorepo
