This revision was automatically updated to reflect the committed changes.
Closed by commit rL364867: [analyzer] NFC: CallDescription: Implement
describing C library functions. (authored by dergachev, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed pr
NoQ updated this revision to Diff 207406.
NoQ added a comment.
Rebase!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62556/new/
https://reviews.llvm.org/D62556
Files:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h
clang/lib/StaticAnalyzer/Core/CallEvent.cpp
cla
Charusso accepted this revision.
Charusso added a comment.
I have not seen any problem. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62556/new/
https://reviews.llvm.org/D62556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ updated this revision to Diff 206978.
NoQ marked 4 inline comments as done.
NoQ added a comment.
Fxd.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62556/new/
https://reviews.llvm.org/D62556
Files:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h
clang/lib/Stat
NoQ added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1064
// e.g. "{a, b}" represent the qualified names, like "a::b".
std::vector QualifiedName;
unsigned RequiredArgs;
a_sidorin wrote:
> Not for this
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Once Aleksei's comments are resolved it is good to go. My comments are notes
and not requests.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallE
Szelethus added a comment.
I like the idea, but will need more time to get familiar with `CallEvent` to
formally accept.
> When matching C standard library functions in the checker, it's easy to
> forget that they are often implemented as macros that are expanded to
> compiler builtins. Such b
a_sidorin added a comment.
Hi Artem,
Looks mostly good, but I have some comments inline.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1064
// e.g. "{a, b}" represent the qualified names, like "a::b".
std::vector QualifiedName;
unsigned
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs,
mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet.
Herald added a project: clang.
NoQ added a parent revision: D62441: [an
