[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added a comment. Sorry for the delay! I rebased the patch onto latest and it mostly worked, with a few hitches. Comment at: clang/lib/Sema/SemaCast.cpp:2617-2619 + (Self.getLangOpts().OpenCL && + (DestPPointee->isFunctionType() || +

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan updated this revision to Diff 444638. ebevhan added a comment. Herald added a subscriber: steakhal. Rebased and addressed some comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574 Files:

[PATCH] D62574: Add support for target-configurable address spaces.

rjmccall added a comment. I completely lost track of this, but if you'd like to rebase it, I can try to make time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added a comment. I've been away from LLVM development for a while, and sadly this patch has languished a bit. I don't think there were any strong objections to its inclusion, though. If there is still interest in reviewing this, I could try to rebase the patch (or something resembling

[PATCH] D62574: Add support for target-configurable address spaces.

rjmccall added a comment. Sorry for never actually reviewing this. I have no objection to taking a refactor that implements the Embedded C address-space overlap rules even if we don't have an in-tree target that uses it. I'll try to find time to review. Repository: rG LLVM Github Monorepo

[PATCH] D62574: Add support for target-configurable address spaces.

danilaml added a comment. So is missing an in-tree user (like AMDGPU) the only thing that prevents from merging this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574

[PATCH] D62574: Add support for target-configurable address spaces.

Anastasia added a comment. In D62574#2249817 , @ebevhan wrote: > In D62574#2242471 , @Anastasia wrote: > >> The only thing is that it would be good to test the new target setting logic >> somehow... do you have

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:10963 +bool +ASTContext::isExplicitAddrSpaceConversionLegal(LangAS From, LangAS To) const { + // If From and To overlap, the cast is legal. ebevhan wrote: > Anastasia wrote: > > Btw I

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added a comment. In D62574#2242471 , @Anastasia wrote: > The only thing is that it would be good to test the new target setting logic > somehow... do you have any ideas in mind? We could think of creating a dummy > target for that or adding a

[PATCH] D62574: Add support for target-configurable address spaces.

Anastasia added a comment. Herald added a subscriber: bjope. This change looks good to me in general conceptually as it is completing missing logic in clang that let's targets to customize the address space behavior! The change also looks good from the implementation side apart from some small

[PATCH] D62574: Add support for target-configurable address spaces.

Anastasia added a comment. In D62574#2210503 , @ebevhan wrote: > I think this works now. It should probably be given a few more reviewers to > have a look. Do you have some suggestions, @Anastasia ? Great! I will look at this again within a week or so.

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added a comment. I think this works now. It should probably be given a few more reviewers to have a look. Do you have some suggestions, @Anastasia ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan updated this revision to Diff 284765. ebevhan retitled this revision from "Initial draft of target-configurable address spaces." to "Add support for target-configurable address spaces.". ebevhan edited the summary of this revision. ebevhan added a comment. Rebased and updated summary.